Content-Type: multipart/mixed; boundary="------------hPyyku8CMuxe9Ux1Px19FkO8"
Message-ID: <d38b5a63-fb0d-43ad-a9a9-456f2bcb1a96@oss.nttdata.com>
Date: Tue, 8 Oct 2024 21:42:48 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: May be BUG. Periodic burst growth of the checkpoint_req counter
 on replica.
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>,
 Alexander Korotkov <aekorotkov@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>,
 "Anton A. Melnikov" <aamelnikov@inbox.ru>, Andres Freund
 <andres@anarazel.de>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <99b2ccd1-a77a-962a-0837-191cdf56c2b9@inbox.ru>
 <CAPpHfduW_LbrU1JPtEDek5Fj3_=GZRU=qvFMyg7hnky7BLCGVw@mail.gmail.com>
 <CABUevExav5-SR0x+G9kBUMV0G8XsvSUfuyyqmYBBJi6VHns6sw@mail.gmail.com>
 <CAPpHfdtfDPEy4Pf1n2LvhsQ8ZsE40=OcFf=+U3BAQvfCtdj0MQ@mail.gmail.com>
 <3ed0590b-8132-482e-a9e6-bd694e4a48d7@postgrespro.ru>
 <CAPpHfduFpdq0dUsF=SmTtYit684JoSQrXvzhA+hap-tCA8Z2cA@mail.gmail.com>
 <CAPpHfdss-+EZHUP_MMNm9wHm43+ZM84ERWZvGO+p-5kH_Qt6og@mail.gmail.com>
 <9ea77f40-818d-4841-9dee-158ac8f6e690@oss.nttdata.com>
 <77032579-4dc3-4552-9a09-30aaa114c144@postgrespro.ru>
 <206e58c1-d8f6-4ac3-8f40-7e4c17459473@oss.nttdata.com>
 <a9cbe052-7cd2-46d2-a688-c7b08919db83@postgrespro.ru>
 <82f03b0b-00c6-42b4-95c7-f2eca7fed1ea@oss.nttdata.com>
 <a7f75d42-3a2e-4d70-a1b1-27c8706d2897@postgrespro.ru>
 <4640258e-d959-4cf0-903c-cd02389c3e05@oss.nttdata.com>
 <8e5f353f-8b31-4a8e-9cfa-c037f22b4aee@postgrespro.ru>
 <2adc5283-ae2c-424a-babf-0247eeebf5a3@oss.nttdata.com>
In-Reply-To: <2adc5283-ae2c-424a-babf-0247eeebf5a3@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/d38b5a63-fb0d-43ad-a9a9-456f2bcb1a96%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------hPyyku8CMuxe9Ux1Px19FkO8
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/09/30 12:26, Fujii Masao wrote:
>>> In 0002.patch, I also modified the description of num_requested from
>>> "Number of backend requested checkpoints" to remove "backend," as it can
>>> be confusing since num_requested includes requests from sources other than
>>> the backend. Thought?
>>
>> Agreed. E.g. from xlog. Then maybe changed it also in the function
>> descriptions in the pg_proc.dat? For pg_stat_get_checkpointer_num_requested()
>> and pg_stat_get_checkpointer_restartpoints_requested().
> 
> Yes, good catch!

Patch attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------hPyyku8CMuxe9Ux1Px19FkO8
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-Improve-descriptions-of-some-pg_stat_checkpoints-.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-Improve-descriptions-of-some-pg_stat_checkpoints-.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA1YzkzNWY1MjYzZmM0ZDUxNmNlYWY4ZDQ2YzJhMDZkYWYwMzVmMWY3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFR1ZSwgOCBPY3QgMjAyNCAyMToxMjo0OCArMDkwMApTdWJqZWN0OiBbUEFU
Q0ggdjFdIEltcHJvdmUgZGVzY3JpcHRpb25zIG9mIHNvbWUgcGdfc3RhdF9jaGVja3BvaW50
cyBmdW5jdGlvbnMKIGluIHBnX3Byb2MuZGF0LgoKUHJldmlvdXNseSwgdGhlIGRlc2NyaXB0
aW9ucyBvZiBwZ19zdGF0X2dldF9jaGVja3BvaW50ZXJfbnVtX3JlcXVlc3RlZCgpLApwZ19z
dGF0X2dldF9jaGVja3BvaW50ZXJfcmVzdGFydHBvaW50c19yZXF1ZXN0ZWQoKSwKYW5kIHBn
X3N0YXRfZ2V0X2NoZWNrcG9pbnRlcl9yZXN0YXJ0cG9pbnRzX3BlcmZvcm1lZCgpIGluIHBn
X3Byb2MuZGF0CnJlZmVycmVkIHRvICJiYWNrZW5kIi4gVGhpcyB3YXMgbWlzbGVhZGluZyBi
ZWNhdXNlIHRoZXNlIGZ1bmN0aW9ucyByZXBvcnQKdGhlIG51bWJlciBvZiBjaGVja3BvaW50
cyBvciByZXN0YXJ0cG9pbnRzIHJlcXVlc3RlZCBvciBwZXJmb3JtZWQKYnkgb3RoZXIgdGhh
biBiYWNrZW5kcyBhcyB3ZWxsLgoKVGhpcyBjb21taXQgcmVtb3ZlcyAiYmFja2VuZCIgZnJv
bSB0aGVzZSBkZXNjcmlwdGlvbnMgdG8gYXZvaWQgY29uZnVzaW9uLgotLS0KIHNyYy9pbmNs
dWRlL2NhdGFsb2cvcGdfcHJvYy5kYXQgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMg
aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVk
ZS9jYXRhbG9nL3BnX3Byb2MuZGF0IGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9jLmRh
dAppbmRleCA3N2Y1NGE3OWU2Li4yYmExNDRhN2FhIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVk
ZS9jYXRhbG9nL3BnX3Byb2MuZGF0CisrKyBiL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdfcHJv
Yy5kYXQKQEAgLTU4MTYsNyArNTgxNiw3IEBACiAgIHByb3BhcmFsbGVsID0+ICdyJywgcHJv
cmV0dHlwZSA9PiAnaW50OCcsIHByb2FyZ3R5cGVzID0+ICcnLAogICBwcm9zcmMgPT4gJ3Bn
X3N0YXRfZ2V0X2NoZWNrcG9pbnRlcl9udW1fdGltZWQnIH0sCiB7IG9pZCA9PiAnMjc3MCcs
Ci0gIGRlc2NyID0+ICdzdGF0aXN0aWNzOiBudW1iZXIgb2YgYmFja2VuZCByZXF1ZXN0ZWQg
Y2hlY2twb2ludHMgc3RhcnRlZCBieSB0aGUgY2hlY2twb2ludGVyJywKKyAgZGVzY3IgPT4g
J3N0YXRpc3RpY3M6IG51bWJlciBvZiByZXF1ZXN0ZWQgY2hlY2twb2ludHMgc3RhcnRlZCBi
eSB0aGUgY2hlY2twb2ludGVyJywKICAgcHJvbmFtZSA9PiAncGdfc3RhdF9nZXRfY2hlY2tw
b2ludGVyX251bV9yZXF1ZXN0ZWQnLCBwcm92b2xhdGlsZSA9PiAncycsCiAgIHByb3BhcmFs
bGVsID0+ICdyJywgcHJvcmV0dHlwZSA9PiAnaW50OCcsIHByb2FyZ3R5cGVzID0+ICcnLAog
ICBwcm9zcmMgPT4gJ3BnX3N0YXRfZ2V0X2NoZWNrcG9pbnRlcl9udW1fcmVxdWVzdGVkJyB9
LApAQCAtNTgzMSwxMyArNTgzMSwxMyBAQAogICBwcm9wYXJhbGxlbCA9PiAncicsIHByb3Jl
dHR5cGUgPT4gJ2ludDgnLCBwcm9hcmd0eXBlcyA9PiAnJywKICAgcHJvc3JjID0+ICdwZ19z
dGF0X2dldF9jaGVja3BvaW50ZXJfcmVzdGFydHBvaW50c190aW1lZCcgfSwKIHsgb2lkID0+
ICc2MzI4JywKLSAgZGVzY3IgPT4gJ3N0YXRpc3RpY3M6IG51bWJlciBvZiBiYWNrZW5kIHJl
cXVlc3RlZCByZXN0YXJ0cG9pbnRzIHN0YXJ0ZWQgYnkgdGhlIGNoZWNrcG9pbnRlcicsCisg
IGRlc2NyID0+ICdzdGF0aXN0aWNzOiBudW1iZXIgb2YgcmVxdWVzdGVkIHJlc3RhcnRwb2lu
dHMgc3RhcnRlZCBieSB0aGUgY2hlY2twb2ludGVyJywKICAgcHJvbmFtZSA9PiAncGdfc3Rh
dF9nZXRfY2hlY2twb2ludGVyX3Jlc3RhcnRwb2ludHNfcmVxdWVzdGVkJywKICAgcHJvdm9s
YXRpbGUgPT4gJ3MnLCBwcm9wYXJhbGxlbCA9PiAncicsIHByb3JldHR5cGUgPT4gJ2ludDgn
LAogICBwcm9hcmd0eXBlcyA9PiAnJywKICAgcHJvc3JjID0+ICdwZ19zdGF0X2dldF9jaGVj
a3BvaW50ZXJfcmVzdGFydHBvaW50c19yZXF1ZXN0ZWQnIH0sCiB7IG9pZCA9PiAnNjMyOScs
Ci0gIGRlc2NyID0+ICdzdGF0aXN0aWNzOiBudW1iZXIgb2YgYmFja2VuZCBwZXJmb3JtZWQg
cmVzdGFydHBvaW50cycsCisgIGRlc2NyID0+ICdzdGF0aXN0aWNzOiBudW1iZXIgb2YgcmVz
dGFydHBvaW50cyBwZXJmb3JtZWQgYnkgdGhlIGNoZWNrcG9pbnRlcicsCiAgIHByb25hbWUg
PT4gJ3BnX3N0YXRfZ2V0X2NoZWNrcG9pbnRlcl9yZXN0YXJ0cG9pbnRzX3BlcmZvcm1lZCcs
CiAgIHByb3ZvbGF0aWxlID0+ICdzJywgcHJvcGFyYWxsZWwgPT4gJ3InLCBwcm9yZXR0eXBl
ID0+ICdpbnQ4JywKICAgcHJvYXJndHlwZXMgPT4gJycsCi0tIAoyLjQ2LjIKCg==

--------------hPyyku8CMuxe9Ux1Px19FkO8--