Message-ID: <d391a8cf-7168-a91c-c8be-9713b2c6f6be@gmail.com>
Date: Mon, 10 Oct 2022 15:04:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: Query Jumbling for CALL and SET utility statements
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
 Julien Rouhaud <rjuju123@gmail.com>, Jeremy Schneider <schnjere@amazon.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Pavel Stehule <pavel.stehule@gmail.com>, Andres Freund <andres@anarazel.de>,
 "Imseih (AWS), Sami" <simseih@amazon.com>
References: <20220908112919.2ytxpkitiw6lt2u6@jrouhaud>
 <a16d303f-39ad-319c-18ff-85b78b106fe1@amazon.com>
 <a0d66747-3f8c-5346-5baa-61299e2cb4da@amazon.com>
 <37d32e91-4a08-afaf-a3a8-fd0578e4db50@oss.nttdata.com>
 <706ee610-4297-453b-f6f2-1e79161414f6@gmail.com>
 <6d0d8a57-0e9c-7fcb-5072-aae544dafa5c@gmail.com>
 <Yz54LU3WEYiDKS1R@paquier.xyz>
 <66be1104-164f-dcb8-6c43-f03a68a139a7@gmail.com>
 <Yz+f2VFqbDELGm2j@paquier.xyz> <3088762.1665114712@sss.pgh.pa.us>
 <Yz+nUUVc3UtJtU6q@paquier.xyz>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <Yz+nUUVc3UtJtU6q@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d391a8cf-7168-a91c-c8be-9713b2c6f6be%40gmail.com>
Precedence: bulk

Hi,

On 10/7/22 6:13 AM, Michael Paquier wrote:
> On Thu, Oct 06, 2022 at 11:51:52PM -0400, Tom Lane wrote:
>> I've been thinking since the beginning of this thread that there
>> was no coherent, defensible rationale being offered for jumbling
>> some utility statements and not others.
> 
> Yeah.  The potential performance impact of all the TransactionStmts
> worries me a bit, though.
> 
>> I wonder if the answer is to jumble them all.  We avoided that
>> up to now because it would imply a ton of manual effort and
>> future code maintenance ... but now that the backend/nodes/
>> infrastructure is largely auto-generated, could we auto-generate
>> the jumbling code?

I think that's a good idea.

> 
> Probably.  One part that may be tricky though is the location of the
> constants we'd like to make generic, but perhaps this could be handled
> by using a dedicated variable type that just maps to int?  

It looks to me that we'd also need to teach the perl parser which fields 
per statements struct need to be jumbled (or more probably which ones to 
exclude from the jumbling, for example funccall in CallStmt). Not sure 
yet how to teach the perl parser, but I'll build this list first to help 
decide for a right approach, unless you already have some thoughts about it?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com