Message-ID: <d398f38f-2444-451e-8fc4-58a9878541df@iki.fi>
Date: Tue, 6 Aug 2024 14:28:38 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fix comments in instr_time.h and remove an unneeded cast to int64
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <ZrHkv3MAQfwNSmTG@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <ZrHkv3MAQfwNSmTG@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/d398f38f-2444-451e-8fc4-58a9878541df%40iki.fi>
Precedence: bulk

On 06/08/2024 11:54, Bertrand Drouvot wrote:
> Hi hackers,
> 
> While working on [1], I came across what seems to be incorrect comments in
> instr_time.h and an unneeded cast to int64.
> 
> Indeed, 03023a2664 represented time as an int64 on all platforms but forgot to
> update the comment related to INSTR_TIME_GET_MICROSEC() and provided an incorrect
> comment for INSTR_TIME_GET_NANOSEC().
> 
> Please find attached a tiny patch to correct those and, in passing, remove what
> I think is an unneeded cast to int64.

Applied, thanks!

-- 
Heikki Linnakangas
Neon (https://neon.tech)