Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo34S-0007bq-VT for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Oct 2022 13:37:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oo34R-0008R4-Q7 for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Oct 2022 13:37:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo34R-0008Qv-Gc for pgsql-hackers@lists.postgresql.org; Thu, 27 Oct 2022 13:37:19 +0000 Received: from mail-oa1-x42.google.com ([2001:4860:4864:20::42]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oo34P-0001Mj-57 for pgsql-hackers@lists.postgresql.org; Thu, 27 Oct 2022 13:37:19 +0000 Received: by mail-oa1-x42.google.com with SMTP id 586e51a60fabf-12c8312131fso1998666fac.4 for ; Thu, 27 Oct 2022 06:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=2wUJkQoLfUGH5UfzRLhOwCVxTk+VqNSWanZjOTwLFIU=; b=DYWvmhDZ8xeicHK6b+ao3/jsDa1WQ633LUKFUK8GRv5MJtk8aL/P/Qzlh8HRyg01Fp PttTWpWMqQEUnOsMMvvmEVrpvoe2Io8bQS+FGpKq5aWuraU3TMzp0ReelcZouqe1qGJT bEdzoxfP3Ii1il9izjobzPTYD32N70v9WY91ImJxu1IGwp6B9p6X9gLF2NbCLc0zhofA DS355QiN1/3pBbxw0JcbHKw6mrvajd6lNGd4r3jy/gVJRZnefpc1ANIl6SwQzsYHHsja NZ8+Ydmi3QhvnRFOQlU1tiyfqxD1kHzL3h7Ay/Be4MVxz2gJNZbxuYzCbXBmA31TqYkO NBWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2wUJkQoLfUGH5UfzRLhOwCVxTk+VqNSWanZjOTwLFIU=; b=iEQX/PREKTnXDHfR0jbSP9z/J5xhARs3JTjE7e8D5PwGS11+wb1miTL5Qm428xsBBF DIL1WBntbUUDIEBXcnwL40wmatKGa2WuysXOH1suA1+riVoOdqdBhU8n9Obk3XIYWiG2 /YzmJ+NTZrbVuYzUfI48UFH7CKwaXKbbFQ+KrTly+bc+cuV7DMZuea2ZnycHyXbwUktj PovHLuU14+fTU9j0lQIqOsjoy3K0vTt8NkfEmiZx3gPdZOWLltSuw+6ZlN5PJMkUs+sq 6PFfwg1bquWvxpK7J9tPKbwDyEUsLDVUCBE5aCMR0CTb5MdhFFXiLXFX5G0W2/k9vsf/ LqEA== X-Gm-Message-State: ACrzQf0265mWwKYYFDCovjWfMM/hUEsMhjAbAiFzI0Lpn1hpi01HzwtB wR0MamYaZ/nx7ZKNFEhSHiG/+pceus4= X-Google-Smtp-Source: AMsMyM6+uvuXoex/CturEIvKwLur+e/mFBblfADT8zgH+/8kmgmOESzmQN92CQDwPNjfZs6AqU9+XQ== X-Received: by 2002:a05:6870:5890:b0:136:8cc1:1aa6 with SMTP id be16-20020a056870589000b001368cc11aa6mr5568551oab.21.1666877833617; Thu, 27 Oct 2022 06:37:13 -0700 (PDT) Received: from [198.18.17.166] ([103.6.219.221]) by smtp.gmail.com with ESMTPSA id y62-20020a4a4541000000b0047634c1c419sm465741ooa.12.2022.10.27.06.37.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2022 06:37:13 -0700 (PDT) Date: Thu, 27 Oct 2022 21:37:04 +0800 From: Zhang Mingli To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org Message-ID: In-Reply-To: <644164.1666877342@sss.pgh.pa.us> References: <78062.1666735746@sss.pgh.pa.us> <2faecd55-6786-471c-84ac-36aa7149abee@Spark> <644164.1666877342@sss.pgh.pa.us> Subject: Re: Reducing duplicativeness of EquivalenceClass-derived clauses X-Readdle-Message-ID: d3b254ff-adc1-4264-a9f3-c40be30d53eb@Spark MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="635a8985_69e373_1189" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --635a8985_69e373_1189 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, On Oct 27, 2022, 21:29 +0800, Tom Lane , wrote: > Zhang Mingli writes: > > How about combine ec->ec_sources and ec->derives as one list for less codes? > > Keeping them separate is required for the broken-EC code paths. > Even if it weren't, I wouldn't merge them just to save a couple > of lines of code --- I think it's useful to be able to tell which > clauses the EC started from. > > regards, tom lane Got it, thanks. Regards, Zhang Mingli --635a8985_69e373_1189 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Hi,

On Oct 27, 2022, 21:29 +0800, Tom Lane <tgl=40sss.pgh.pa.us>, wrote= :
Zhang Mingli <zmlpostgres=40gmail.com> writes:
How about combine ec->ec=5Fsources and ec->derives as one list for= less codes=3F

Keeping them separate is required for the broken-EC code paths.
Even if it weren't, I wouldn't merge them just to save a couple
of lines of code --- I think it's useful to be able to tell which
clauses the EC started from.

regards, tom lane
Got it, thanks.

Regards,
Zhang Mingli
--635a8985_69e373_1189--