To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
Subject: Extra quote_all_identifiers in _dumpOptions
Message-ID: <d3d92ce9-78a4-8adb-0393-d3deeec29f7e@postgrespro.ru>
Date: Thu, 27 Jun 2019 12:12:15 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------E67D81C5AD5009E440A4A885"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------E67D81C5AD5009E440A4A885
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello hackers,

While working on pg_dump I noticed the extra quote_all_identifiers in 
_dumpOptions struct. I attached the patch.

It came from refactoring by 0eea8047bf. There is also a discussion:
https://www.postgresql.org/message-id/CACw0%2B13ZUcXbj9GKJNGZTkym1SXhwRu28nxHoJMoX5Qwmbg_%2Bw%40mail.gmail.com

Initially the patch proposed to use quote_all_identifiers of 
_dumpOptions. But then everyone came to a decision to use global 
quote_all_identifiers from string_utils.c, because fmtId() uses it.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

--------------E67D81C5AD5009E440A4A885
Content-Type: text/x-patch;
 name="extra_quote_all_identifiers.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="extra_quote_all_identifiers.patch"

diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h
index db30b54a92..8c0cedcd98 100644
--- a/src/bin/pg_dump/pg_backup.h
+++ b/src/bin/pg_dump/pg_backup.h
@@ -153,7 +153,6 @@ typedef struct _dumpOptions
 	int			no_synchronized_snapshots;
 	int			no_unlogged_table_data;
 	int			serializable_deferrable;
-	int			quote_all_identifiers;
 	int			disable_triggers;
 	int			outputNoTablespaces;
 	int			use_setsessauth;

--------------E67D81C5AD5009E440A4A885--