MIME-Version: 1.0
Date: Wed, 14 Jan 2026 15:32:34 +0700
From: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
To: Soumya S Murali <soumyamurali.work@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: 001_password.pl fails with --without-readline
In-Reply-To: 
 <CAMtXxw_kvxZPMnUu5dgTyVwRhwgaFDXAMW4UwhOuUURKHT6U1Q@mail.gmail.com>
References: <db6fdb35a8665ad3c18be01181d44b31@postgrespro.ru>
 <CAMtXxw_kvxZPMnUu5dgTyVwRhwgaFDXAMW4UwhOuUURKHT6U1Q@mail.gmail.com>
Message-ID: <d45671ce55b7b0434c620cebf7373d84@postgrespro.ru>
Organization: Postgres Pro
Content-Type: multipart/mixed;
 boundary="=_6fc6c62826e9920c856c3f12f05a91b9"
Archived-At: 
 <https://www.postgresql.org/message-id/d45671ce55b7b0434c620cebf7373d84%40postgrespro.ru>
Precedence: bulk

--=_6fc6c62826e9920c856c3f12f05a91b9
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Thanks for your patch!

I like your behaviour-based approach more, but I have some questions
about the patch itself

1) There is a comment in query() function:
# We need to match for the newline, because we try to remove it below, 
and
# it's possible to consume just the input *without* the newline. In
# interactive psql we emit \r\n, so we need to allow for that. Also need
# to be careful that we don't e.g. match the echoed \echo command, 
rather
# than its output.

So, originally, checking that the banner is on it's own line is needed
to distiguish \echo $banner and \warn $banner from their output.

It seems that your patch does not distingush them all the time

(taken from query() function with your patch applied)
	my $banner_detect_stdout = qr/\Q$banner\E/;
	my $banner_detect_stderr = qr/(^|\n)\Q$banner\E\r?\n/;

Why do you check stderr for newline but not the stdout?

2) Why did you add /Q/E around the $banner variable? It doesn't
contain any regex metacharacters (in query() function there is
$query_cnt inside of $banner, but it should be substituted by Perl).
Maybe it is really necessary and I just don't get it

-----

While testing and checking, I've made a new patch. It's very
simple and it just checks that there is banner in a string, but
the string doesn't start with \echo or \warn

Maybe it needs some additional comments, but lets decide on which
approach to use

-----

There is also a problem of test src/bin/psql/t/030_pager.pl - it
just doesn't work with --without-readline, all regexes seem to be right
and debug output shows correct data. None of our patches
currently solve it, I'll look into it

-----

Regards,
Oleg
--=_6fc6c62826e9920c856c3f12f05a91b9
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=v2-0001-background-psql-without-readline.patch
Content-Disposition: attachment;
 filename=v2-0001-background-psql-without-readline.patch;
 size=1206

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L0JhY2tncm91bmRQc3Fs
LnBtIGIvc3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvQmFja2dyb3VuZFBzcWwucG0KaW5k
ZXggNWJkNDFhMjc4ZGQuLjFhNzdlYWU4ZDg0IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9wZXJsL1Bv
c3RncmVTUUwvVGVzdC9CYWNrZ3JvdW5kUHNxbC5wbQorKysgYi9zcmMvdGVzdC9wZXJsL1Bvc3Rn
cmVTUUwvVGVzdC9CYWNrZ3JvdW5kUHNxbC5wbQpAQCAtMTU1LDExICsxNTUsMTEgQEAgc3ViIHdh
aXRfY29ubmVjdAogCSMKIAkjIFNlZSBxdWVyeSgpIGZvciBkZXRhaWxzIGFib3V0IHdoeS9ob3cg
dGhlIGJhbm5lciBpcyB1c2VkLgogCW15ICRiYW5uZXIgPSAiYmFja2dyb3VuZF9wc3FsOiByZWFk
eSI7Ci0JbXkgJGJhbm5lcl9tYXRjaCA9IHFyLyhefFxuKSRiYW5uZXJccj9cbi87CisJbXkgJGJh
bm5lcl9tYXRjaCA9IHFyLyhefFxuKSg/IVxcZWNob3xcXHdhcm4pLiokYmFubmVyXHI/XG4vOwog
CSRzZWxmLT57c3RkaW59IC49ICJcXGVjaG8gJGJhbm5lclxuXFx3YXJuICRiYW5uZXJcbiI7CiAJ
JHNlbGYtPntydW59LT5wdW1wKCkKIAkgIHVudGlsICgkc2VsZi0+e3N0ZG91dH0gPX4gLyRiYW5u
ZXJfbWF0Y2gvCi0JCSAgJiYgJHNlbGYtPntzdGRlcnJ9ID1+IC8kYmFubmVyXHI/XG4vKQorCQkg
ICYmICRzZWxmLT57c3RkZXJyfSA9fiAvJGJhbm5lcl9tYXRjaC8pCiAJICB8fCAkc2VsZi0+e3Rp
bWVvdXR9LT5pc19leHBpcmVkOwogCiAJbm90ZSAiY29ubmVjdCBvdXRwdXQ6XG4iLApAQCAtMjcw
LDcgKzI3MCw3IEBAIHN1YiBxdWVyeQogCSMgdG8gYmUgY2FyZWZ1bCB0aGF0IHdlIGRvbid0IGUu
Zy4gbWF0Y2ggdGhlIGVjaG9lZCBcZWNobyBjb21tYW5kLCByYXRoZXIKIAkjIHRoYW4gaXRzIG91
dHB1dC4KIAlteSAkYmFubmVyID0gImJhY2tncm91bmRfcHNxbDogUVVFUllfU0VQQVJBVE9SICRx
dWVyeV9jbnQ6IjsKLQlteSAkYmFubmVyX21hdGNoID0gcXIvKF58XG4pJGJhbm5lclxyP1xuLzsK
KwlteSAkYmFubmVyX21hdGNoID0gcXIvKF58XG4pKD8hXFxlY2hvfFxcd2FybikuKiRiYW5uZXJc
cj9cbi87CiAJJHNlbGYtPntzdGRpbn0gLj0gIiRxdWVyeVxuO1xuXFxlY2hvICRiYW5uZXJcblxc
d2FybiAkYmFubmVyXG4iOwogCXB1bXBfdW50aWwoCiAJCSRzZWxmLT57cnVufSwgJHNlbGYtPnt0
aW1lb3V0fSwK
--=_6fc6c62826e9920c856c3f12f05a91b9--