Subject: Re: WIP: Aggregation push-down
To: Laurenz Albe <laurenz.albe@cybertec.at>, Antonin Houska <ah@cybertec.at>,
 Tom Lane <tgl@sss.pgh.pa.us>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andy Fan <zhihui.fan1213@gmail.com>,
 legrand legrand <legrand_legrand@hotmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Daniel Gustafsson <daniel@yesql.se>
References: <11172.1550780283@sss.pgh.pa.us> <23468.1551369774@localhost>
 <CAN_9JTy95UMjOVDSc-4MBrA6Fc1hX2vh=t2RMHp=yGyAV=-Xsw@mail.gmail.com>
 <1897.1562680064@spoje.net>
 <CAN_9JTzC1K-Gc3p5GD=dQeJD8k_Z5996B0rEYjVGx+pXPq8JPw@mail.gmail.com>
 <13971.1562920911@spoje.net>
 <CAN_9JTzAsBwv5zr4SRVO35OtMWQBXSLcUuY65NQ0ZtFCTOrMMA@mail.gmail.com>
 <19857.1563374392@localhost> <20190904202339.GA13644@alvherre.pgsql>
 <7087.1567663858@localhost> <1582751446111-0.post@n3.nabble.com>
 <20715.1582793501@antos>
 <CAKU4AWqK_X4L5WDsjnsFpm_Gt8Mx0+H4frC-6Pom1ro=aq44mQ@mail.gmail.com>
 <50402.1587730290@antos>
 <CAKU4AWpzp1ZaDdD+hX8q4zpXhgNg9S93zNwmAc4Q3h5Xqj0NSA@mail.gmail.com>
 <86487.1589876240@antos> <81070927-E32E-4711-86E7-7ECC9E9F1EE5@yesql.se>
 <b5bfb07c6e3f2238c84ef113353cd36a55811dda.camel@cybertec.at>
From: David Steele <david@pgmasters.net>
Message-ID: <d4a7ca04-50c7-9a36-a8fc-ed459ea24c72@pgmasters.net>
Date: Wed, 3 Mar 2021 11:42:05 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <b5bfb07c6e3f2238c84ef113353cd36a55811dda.camel@cybertec.at>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d4a7ca04-50c7-9a36-a8fc-ed459ea24c72%40pgmasters.net>
Precedence: bulk

On 7/3/20 6:07 AM, Laurenz Albe wrote:
> On Thu, 2020-07-02 at 14:39 +0200, Daniel Gustafsson wrote:
>> This version now fails to apply to HEAD, with what looks like like a trivial
>> error in the expected test output.  Can you please submit a rebased version so
>> we can see it run in the patch tester CI?  I'm marking the entry as Waiting on
>> Author in the meantime.
> 
> I have rebased the patch against current HEAD, it passes "make installcheck".

This needs another rebase so marked as Waiting on Author: 
http://cfbot.cputube.org/patch_32_1247.log

As far as I can see reviewer concerns have been addressed as they have 
come up, but as Tomas noted this is a bit of a niche feature as far as 
who might commit it.

Tom, Tomas, would you care to share your remaining concerns, if any?

Regards,
-- 
-David
david@pgmasters.net