Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBAxl-002IFJ-22 for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Nov 2024 10:51:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tBAxh-00DFzt-JW for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Nov 2024 10:51:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBAxh-00DFzk-95 for pgsql-hackers@lists.postgresql.org; Wed, 13 Nov 2024 10:51:01 +0000 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tBAxd-001hs2-U5 for pgsql-hackers@lists.postgresql.org; Wed, 13 Nov 2024 10:51:01 +0000 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id ADBAD11401F7; Wed, 13 Nov 2024 05:50:56 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Wed, 13 Nov 2024 05:50:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1731495056; x=1731581456; bh=tqXl1xCxqNFciIrFpSCF6/X6L3zDOfPD O/PC0cukXMU=; b=e7tNKzMhHRqeeEAaZAyB8fB5FF6CKpvlq9k8Zclxr7mkvr+x JMHd/W1CFjZCdXWRrvpFQ6UNbMyrNdkyocbQWo/nttV9wGEoz6fHSUDkvkqXt2gW UOaKHWCdg3AJiSMF8TVFndtW3it9nx5dSLM+Q2nihobtezYEef0X86DHR43GoVtq vkDrq/iMnr7b76v7MKaEdqwRU4B8cjMEBd3252IUBL8O6BRhS+gbnwDkGk367oUm g49EJKnlM877a0neFvhW0UQMl9OwOWJhRhNt9TcjA33q5AXd0kkh8Qpegj/L9hHb t+u+VuxCbC3r5sZ5hiebhGF8qcRVXUkMuGFGsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731495056; x= 1731581456; bh=tqXl1xCxqNFciIrFpSCF6/X6L3zDOfPDO/PC0cukXMU=; b=l LL5VPCb17BwsXbPiSeBtTI/JAEA/8ABIeQEUQrPIi1MddaGV7D5D7deebcW9JExG A2zc4vVTbdVslYBIUQHKP2u74JyFzdGDRJnaI97lDCoNUgo8OqJtsSYSjlPaXPO2 IOSi9v8Bm0AXhjd6d2LzlzVQRzVK0EWjgXubM7zYCJ4f0sDNbeJHPyG3qjToqjGg TJbDLNJ0ePKYYkM13JMXCGvy3hb9QvBpYJHGIiJD4xcaSwtgiGRF7gYqjC0RgMwT 6C2K70iOsQ93M0Kt/87skMOIntADolQAhPsdCWYtyCTjMngypE6Y79vqOeWsoyge 6wmT478jEeThvb88EP7yg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvddtgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeen ucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnh htrhgruhhtrdhorhhgqeenucggtffrrghtthgvrhhnpefgjedthfekfedtuefgieelheet leejgefhueeltdfhueetvdffudekfeejhfegheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhr ghdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepph hjsehilhhluhhmihhnrghtvggutghomhhpuhhtihhnghdrtghomhdprhgtphhtthhopehj ihgrnhdruhhnihhvvghrshgrlhhithihsehgmhgrihhlrdgtohhmpdhrtghpthhtohepph hgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Nov 2024 05:50:55 -0500 (EST) Message-ID: Date: Wed, 13 Nov 2024 11:50:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: SQL:2011 application time To: Paul Jungwirth Cc: jian he , PostgreSQL Hackers References: <30dc3561-d7ab-42be-a1c5-096643423590@illuminatedcomputing.com> <73d09e24-b6b9-4c89-8c0a-8842ca0f81f9@illuminatedcomputing.com> <081aa43c-3a97-4bd5-a498-ba02e0a7570d@illuminatedcomputing.com> <54390149-11d6-4f52-bbe8-f69832ceb3bd@eisentraut.org> <9b7cb814-c78c-489f-85b2-32be4398647f@illuminatedcomputing.com> <95c6d49b-7d60-4ad0-820c-e00ae1b2a3d4@illuminatedcomputing.com> <57ea0668-5205-426e-b934-efc89f2186c2@illuminatedcomputing.com> Content-Language: en-US From: Peter Eisentraut In-Reply-To: <57ea0668-5205-426e-b934-efc89f2186c2@illuminatedcomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk A quick comment on the patch v43-0005-Add-UPDATE-DELETE-FOR-PORTION-OF.patch regarding the code in transformForPortionOfClause() and the additions you made to lsyscache.c: What you are doing is taking a type OID and a function OID and then converting them back to name and namespace and then building a node and then feeding that node back through the parse analysis transformation. This all seems quite fishy and cumbersome. I think instead of building a FuncCall and transforming it, try to build a FuncExpr directly. Then you wouldn't need these new helper functions, which would also reduce the surface area of your patch. Additional mini-comment: #include "utils/rangetypes.h" in src/include/nodes/execnodes.h appears to be unnecessary (but it is then required in src/backend/commands/trigger.c).