public inbox for [email protected]  

help / color / mirror / Atom feed

From: Wolfgang Walther <[email protected]>
To: Tom Lane <[email protected]>
To: Sven Klemm <[email protected]>
Cc: [email protected]
Subject: Re: Regression tests fail with tzdata 2024b
Date: Tue, 17 Sep 2024 08:39:53 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAMCrgp1W7DWBNA4GQCKBPyUS7nV15j_8kedkBWX2ud6w1n06Yw@mail.gmail.com>
	<[email protected]>
	<CAMCrgp3vqoUKgLk2nshO-po-s26gEPWXT0wxjOkbrNqQ6TwAaA@mail.gmail.com>
	<[email protected]>

Tom Lane:
>> I was wondering whether the timezone used by pg_regress could be made
>> configurable.
> 
> Yes, I understood that you were suggesting that.  My point is that
> it wouldn't do you any good: you will still have to change any
> regression test cases that depend on behavior PST8PDT has/had that
> is different from America/Los_Angeles.  That being the case,
> I don't see much value in making it configurable.

Just changing it back to PST8PDT wouldn't really help as Tom pointed 
out. You'd still get different results depending on which tzdata version 
you are running with.

The core regression tests need to be run with a timezone that tests 
special cases in the timezone handling code. But that might not be true 
for extensions - all they want could be a stable output across major and 
minor versions of postgres and versions of tzdata. It could be helpful 
to set pg_regress' timezone to UTC, for example?

Best,

Wolfgang

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Regression tests fail with tzdata 2024b
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox