Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsn5X-009QuX-Vc for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 16:38:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qsn5V-00CFjY-MB for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Oct 2023 16:38:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsn5V-00CFjQ-Co for pgsql-hackers@lists.postgresql.org; Tue, 17 Oct 2023 16:38:34 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qsn5S-001CtN-Ch for pgsql-hackers@postgresql.org; Tue, 17 Oct 2023 16:38:33 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6b36e1fcee9so3413030b3a.3 for ; Tue, 17 Oct 2023 09:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1697560709; x=1698165509; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=tpu+ZPnrXib+M/KVVjPUlbjFv6CqZZ7Juaj1k3dBkKQ=; b=u1d0VpTPQabn3mZ0gkHAv5+jeAd+24FBBYSbG1ruYm0vZ53qL0cZlJO/oTzAQH9ndt +XyHrfIZ/Pv834y/TzHRRcZGkr96+NkQUOw327Tb8zHkbNDOyPFCDLF8US7FTtcLnSTK Oir5TwZcY9f0G3T9x07rtJIDHkfErmND9gfJsMZJJpyfcfaObJD+vVycorp1wypMn5kU HMiFceWIHXDA1mae4winRoVSXNI7bbYfwLCpwUqCWoZIRmKFzQf0Lw/LCqxHuRjnVzjn JKfWl7lP1BuWY7lix/TunGH9saA/G/jDN+1PckdSW2pKm8EZcDqsSEag0MilEn8LfSdA jFkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697560709; x=1698165509; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tpu+ZPnrXib+M/KVVjPUlbjFv6CqZZ7Juaj1k3dBkKQ=; b=ZOyCc/ll0Bs5hkaPu1h0Y10QPuaAf3s9uOSv4LuvPQInsWhaPAldirJrYASvyBZP8T lL9S2pBcajgeV0x9xsZhyfe9jFRH2Lam/9zh8RMHZPoSSUUYFXM7vyqR6hsX9YDjkz0p rAhCLHjR17dPfa/uEx0/Qs+g2kfJjMQhqzlUx7WeUBGWVa8ajwM1Lb5FM3PLTvLE7vAR EPkrfs8++iLj/fr5duSCB2+5du6CEl65AgU1pdGsPdqavnxUHLtMlxz4XUBH9xyiEIEn M2AJDsBEdveFrwrLNDuyKRp7fI2R26Z6Ug8yvMDAH+HdhIlau4rCs3whkh7vQ3zya4td RecA== X-Gm-Message-State: AOJu0YyHR/KKia14SlJY1E/kK9PtHtQhlIIJ3l2JyzFsCF5hhIYe+EdL OVDQ+FqHZlouG97LKjQT5puT9AT2QjWdaLw4CEA= X-Google-Smtp-Source: AGHT+IH/C11l0KHKrYxL3vf4eWgFUJlH8LC51Uq8QrUjVZO5RUV2v6+d7Z4No6MBW/WJQFB3vD0z4A== X-Received: by 2002:a05:6a00:1141:b0:6bb:8982:411c with SMTP id b1-20020a056a00114100b006bb8982411cmr2862537pfm.8.1697560709401; Tue, 17 Oct 2023 09:38:29 -0700 (PDT) Received: from [172.24.1.133] ([12.126.244.130]) by smtp.gmail.com with ESMTPSA id w17-20020aa79a11000000b006930db1e6cfsm1665070pfj.62.2023.10.17.09.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 09:38:28 -0700 (PDT) Message-ID: Subject: Re: Is this a problem in GenericXLogFinish()? From: Jeff Davis To: Robert Haas Cc: Heikki Linnakangas , pgsql-hackers@postgresql.org Date: Tue, 17 Oct 2023 09:38:27 -0700 In-Reply-To: References: <25104133-7df8-cae3-b9a2-1c0aaa1c094a@iki.fi> <399492009193fa2c37a61b630e4449546a550039.camel@j-davis.com> <146426fc662f88604c700a72a3833b1919922f9e.camel@j-davis.com> <08b4f1f7dcf321d38373f06acc65a8d62cc2f017.camel@j-davis.com> <6d23aff2-7151-65b1-528b-2189ffa6e2df@iki.fi> <57c59f08bbb92875251dc97dbc47600fa237712c.camel@j-davis.com> <50bebdf8bbf79475e3fc0fff398d77b1577c1b97.camel@j-davis.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 2023-10-17 at 08:41 -0400, Robert Haas wrote: > Sorry, I'm not sure I understand the question. Are you asking whether > dirtying buffers unnecessarily might be slower than not doing that? I meant: are those cleanup operations frequent enough that dirtying those buffers in that case would matter? Regards, Jeff Davis