MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Tue, 25 May 2021 03:58:43 +0300
From: Yura Sokolov <y.sokolov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add PortalDrop in exec_execute_message
In-Reply-To: <4160143.1621621400@sss.pgh.pa.us>
References: <4aa370cb91ecf2f9885d98b80ad1109c@postgrespro.ru>
 <4160143.1621621400@sss.pgh.pa.us>
User-Agent: Roundcube Webmail/1.4.0
Message-ID: <d5527cd4f9e9420b40b4947b375a7112@postgrespro.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/d5527cd4f9e9420b40b4947b375a7112%40postgrespro.ru>
Precedence: bulk

Tom Lane писал 2021-05-21 21:23:
> Yura Sokolov <y.sokolov@postgrespro.ru> writes:
>> I propose to add PortalDrop at the 'if (completed)' branch of
>> exec_execute_message.
> 
> This violates our wire protocol specification, which
> specifically says
> 
>     If successfully created, a named portal object lasts till the end 
> of
>     the current transaction, unless explicitly destroyed. An unnamed
>     portal is destroyed at the end of the transaction, or as soon as 
> the
>     next Bind statement specifying the unnamed portal as destination is
>     issued. (Note that a simple Query message also destroys the unnamed
>     portal.)
> 
> I'm inclined to think that your complaint would be better handled
> by having the client send a portal-close command, if it's not
> going to do something else immediately.

I thought about it as well. Then, if I understand correctly,
PQsendQueryGuts and PQsendQueryInternal in pipeline mode should send
"close portal" (CP) message after "execute" message, right?

regards,
Sokolov Yura