Subject: Re: WIP: System Versioned Temporal Table
To: Daniel Gustafsson <daniel@yesql.se>,
 Simon Riggs <simon.riggs@enterprisedb.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
 Jaime Casanova <jcasanov@systemguards.com.ec>,
 vignesh C <vignesh21@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>,
 Surafel Temesgen <surafel3000@gmail.com>,
 =?UTF-8?Q?R=c3=a9mi_Lapeyre?= <remi.lapeyre@lenstra.fr>,
 Ryan Lambert <ryan@rustprooflabs.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, Eli Marmor <eli@netmask.it>,
 David Steele <david@pgmasters.net>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Georgios <gkokolatos@protonmail.com>, Li Japin <japinli@hotmail.com>
References: 
 <CANbhV-F3S=5+5w19cowPwewBXSV3+C5T3BD327KQD7BLFgZbCQ@mail.gmail.com>
 <CANbhV-H-Wt7TVEwzzaYNEZ8-OteipdtvsxN1Qr1G9XpZoX2GgA@mail.gmail.com>
 <CANbhV-EymXWOFdX-Sz7PqQ8kphqHMteErBgD=FxmE+uF7jVW4w@mail.gmail.com>
 <7990518c-3dd3-4f30-c5e1-e094f6126e9a@postgresfriends.org>
 <CALAY4q-4YpPc=hSGpxCJBVwpTKzm2A5JyoXUr+2Lh0KTiUcjPQ@mail.gmail.com>
 <358FBCC9-F788-4ECE-8104-6825F65D1C56@hotmail.com>
 <CALtqXTeMemTWNUQfa9_M+p=eOcvw5yLyfRReBu2BrAbo8rkYNw@mail.gmail.com>
 <CALDaNm3-8ZvqFOcZwpN6MYV+Apk9=mHTL2SBJJsUmrR_ZdVznA@mail.gmail.com>
 <CANbhV-GeD9PWHMkrZLV2vHASjFk3n2QFhGur6+o1gnAf5wymAg@mail.gmail.com>
 <20210910183023.GB5852@ahch-to>
 <CANbhV-F3JjkfEPffUwGX_rVrQhRRde360+V4-GOuUqJgt78r1g@mail.gmail.com>
 <CADkLM=e5m4_4JBrX__V4J68rU9z8GpcsN3r1RNPcET-ZctG9Gg@mail.gmail.com>
 <CADkLM=ca+9gYjE2bfPWu-rJFHQjGcwOkEep8d841-x4=-h8EZw@mail.gmail.com>
 <CANbhV-ERW0G1B=ALwa+Uh0XX975NnHUwFzDgtukeszowm3KRmA@mail.gmail.com>
 <335B3EDC-ACCD-4312-9783-C2F8FB083D80@yesql.se>
From: Vik Fearing <vik@postgresfriends.org>
Message-ID: <d56b4e27-deab-62ac-1d5f-7710b3afefd4@postgresfriends.org>
Date: Mon, 15 Nov 2021 10:50:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <335B3EDC-ACCD-4312-9783-C2F8FB083D80@yesql.se>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d56b4e27-deab-62ac-1d5f-7710b3afefd4%40postgresfriends.org>
Precedence: bulk

On 11/15/21 10:47 AM, Daniel Gustafsson wrote:
>> On 19 Sep 2021, at 20:32, Simon Riggs <simon.riggs@enterprisedb.com> wrote:
> 
>> My preferred approach would be to do this "for free" in the table
>> access method, but we're a long way from this in terms of actual
>> implementation. When Corey  suggested earlier that we just put the
>> syntax in there, this was the direction I was thinking.
>>
>> After waiting a day since I wrote the above, I think we should go with
>> (2) as Corey suggests, at least for now, and we can always add (3)
>> later.
> 
> This patch no longer applies, are there plans on implementing the approaches
> discussed above, or should we close this entry and open a new one when a
> freshly baked pathed is ready?

I spent a lot of time a while ago trying to fix this patch (not just
rebase it), and I think it should just be rejected, unfortunately.

The design decisions are just too flawed, and it conflates system_time
periods with system versioning which is very wrong.
-- 
Vik Fearing