MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 13 May 2021 17:26:20 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Pgsql
 Hackers <pgsql-hackers@postgresql.org>
Subject: Re: RFC: Logging plan of the running query
In-Reply-To: <1243864f97028b075b9e5b52931fce2ff0896f79.camel@cybertec.at>
References: <cf8501bcd95ba4d727cbba886ba9eea8@oss.nttdata.com>
 <CALj2ACW6HgFQ=WQu=2MajOHXz7o4Hgzt_zb=RVeF5JQiSQcSPA@mail.gmail.com>
 <1243864f97028b075b9e5b52931fce2ff0896f79.camel@cybertec.at>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <d56df22fbb6891405dd83ad136de75f2@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/d56df22fbb6891405dd83ad136de75f2%40oss.nttdata.com>
Precedence: bulk

On 2021-05-13 01:08, Laurenz Albe wrote:
> On Wed, 2021-05-12 at 18:03 +0530, Bharath Rupireddy wrote:
>> Since it also shows up the full query text and the plan
>> in the server log as plain text, there are chances that the sensitive
>> information might be logged into the server log which is a risky thing
>> from security standpoint.

Thanks for the notification!

> I think that is irrelevant.
> 
> A superuser can already set "log_statement = 'all'" to get this.
> There is no protection from superusers, and it is pointless to require 
> that.

AFAIU, since that discussion is whether or not users other than 
superusers
should be given the privilege to execute the backtrace printing 
function,
I think it might be applicable to pg_log_current_plan().

Since restricting privilege to superusers is stricter, I'm going to 
proceed
as it is for now, but depending on the above discussion, it may be 
better to
change it.


Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION