Content-Type: multipart/alternative;
 boundary="------------U0Y00ltV0YzvU9KzfMzlKYJ4"
Message-ID: <d57b4a69-7394-3146-5976-9a1ef27e7972@gmail.com>
Date: Thu, 31 Aug 2023 13:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: cataloguing NOT NULL constraints
Content-Language: en-US
To: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Dean Rasheed <dean.a.rasheed@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org
References: <20230825113833.4li4xnii2h4r3mqd@alvherre.pgsql>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <20230825113833.4li4xnii2h4r3mqd@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/d57b4a69-7394-3146-5976-9a1ef27e7972%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------U0Y00ltV0YzvU9KzfMzlKYJ4
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Alvaro,

25.08.2023 14:38, Alvaro Herrera wrote:
> I have now pushed this again.  Hopefully it'll stick this time.

I've found that after that commit the following query:
CREATE TABLE t(a int PRIMARY KEY) PARTITION BY RANGE (a);
CREATE TABLE tp1(a int);
ALTER TABLE t ATTACH PARTITION tp1 FOR VALUES FROM (0) to (1);

triggers a server crash:
Core was generated by `postgres: law regression [local] ALTER TABLE                                  '.
Program terminated with signal SIGSEGV, Segmentation fault.

warning: Section `.reg-xstate/2194811' in core file too small.
#0  0x0000556007711d77 in MergeAttributesIntoExisting (child_rel=0x7fc30ba309d8,
     parent_rel=0x7fc30ba33f18) at tablecmds.c:15771
15771                                   if (!((Form_pg_constraint) GETSTRUCT(contup))->connoinherit)
(gdb) bt
#0  0x0000556007711d77 in MergeAttributesIntoExisting (child_rel=0x7fc30ba309d8,
     parent_rel=0x7fc30ba33f18) at tablecmds.c:15771
#1  0x00005560077118d4 in CreateInheritance (child_rel=0x7fc30ba309d8, parent_rel=0x7fc30ba33f18)
     at tablecmds.c:15631
...

(gdb) print contup
$1 = (HeapTuple) 0x0

On b0e96f311~1 I get:
ERROR:  column "a" in child table must be marked NOT NULL

Best regards,
Alexander
--------------U0Y00ltV0YzvU9KzfMzlKYJ4
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi Alvaro,<br>
      <br>
      25.08.2023 14:38, Alvaro Herrera wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20230825113833.4li4xnii2h4r3mqd@alvherre.pgsql">
      <pre class="moz-quote-pre" wrap="">I have now pushed this again.  Hopefully it'll stick this time.
</pre>
    </blockquote>
    <br>
    I've found that after that commit the following query:<br>
    CREATE TABLE t(a int PRIMARY KEY) PARTITION BY RANGE (a);<br>
    CREATE TABLE tp1(a int);<br>
    ALTER TABLE t ATTACH PARTITION tp1 FOR VALUES FROM (0) to (1);<br>
    <br>
    triggers a server crash:<br>
    Core was generated by `postgres: law regression [local] ALTER
    TABLE                                  '.<br>
    Program terminated with signal SIGSEGV, Segmentation fault.<br>
    <br>
    warning: Section `.reg-xstate/2194811' in core file too small.<br>
    #0  0x0000556007711d77 in MergeAttributesIntoExisting
    (child_rel=0x7fc30ba309d8, <br>
        parent_rel=0x7fc30ba33f18) at tablecmds.c:15771<br>
    15771                                   if (!((Form_pg_constraint)
    GETSTRUCT(contup))-&gt;connoinherit)<br>
    (gdb) bt<br>
    #0  0x0000556007711d77 in MergeAttributesIntoExisting
    (child_rel=0x7fc30ba309d8, <br>
        parent_rel=0x7fc30ba33f18) at tablecmds.c:15771<br>
    #1  0x00005560077118d4 in CreateInheritance
    (child_rel=0x7fc30ba309d8, parent_rel=0x7fc30ba33f18)<br>
        at tablecmds.c:15631<br>
    ...<br>
    <br>
    (gdb) print contup<br>
    $1 = (HeapTuple) 0x0<br>
    <br>
    On b0e96f311~1 I get:<br>
    ERROR:  column "a" in child table must be marked NOT NULL<br>
    <br>
    Best regards,<br>
    Alexander<br>
    <span style="font-family:monospace"></span>
  </body>
</html>

--------------U0Y00ltV0YzvU9KzfMzlKYJ4--