Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omuWq-00036w-LS for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Oct 2022 10:17:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1omuWn-0001bI-SP for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Oct 2022 10:17:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omuWn-0001b9-Gl for pgsql-hackers@lists.postgresql.org; Mon, 24 Oct 2022 10:17:53 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1omuWl-0000lk-2Q for pgsql-hackers@lists.postgresql.org; Mon, 24 Oct 2022 10:17:52 +0000 Received: by mail-wm1-x32b.google.com with SMTP id l14-20020a05600c1d0e00b003c6ecc94285so6562229wms.1 for ; Mon, 24 Oct 2022 03:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m8duHUKjY9j1MlOw+5CcRqcFkqrKUmqbJfIABpEO2aM=; b=TUj9qo4ae8t5MVyftQJFzUlU7WsWfM4FV891TTz8vib2q8dZ7vEFu8/+9T3Hu4Ihap tlzbad0SXh420bbglDP5EQ2p24AZ+mfj7ixPGrd3tc3UXonddgW2Srfqek2zs/OEWKkn zFHPAJUXg7eJ5Abj66a+OzCTDnkWNYoxIc2ImRM1Dm7Q1EkGiE/xrBobcW58L/AgSjkj o5m6k9tvVqhMLcDCvf4xt2e6doQt2cMY5quA1ZF+XXNKzPAB5nXAMrFz4pFXb4smrqNU rBD1ocyw0ucu4EK7d7tT0DULQdvqhJkPxVHaxfTj96K63VOC981X/6G2YDnv8de77//H abpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m8duHUKjY9j1MlOw+5CcRqcFkqrKUmqbJfIABpEO2aM=; b=yyivI2j9EteOhneIUXZbcvX0/v1aF9Q2XQaBg2jcGoctMSa57w1RKBr4AfazgDXJX/ vcFDorjUyg/K6WhXEappDHWcAcLSfHzlEZK1r/uBGPRxTsW/HkZNx0FLf6q87q3t6nSx AfK0H+YRcSiQDKkyjsY2IZzQp4mBiboweanDc2PUjnjFtm+ekc2hi9ewexVPiwqmllLh CWLmycNAnpEZzjXLhwbzS47Skw9sst2qO7+ilqSZVCbaDMicFJCQeDpfNpDhKg9y5ePb DUIaNGTgUfXfpVA3QSwf7O9O3Hs6Leua3j6sX/n66Lkq+ezEO4sCzeEm20GiJpvx9w/p Chag== X-Gm-Message-State: ACrzQf1mgBvUZx5ccDMO09iWmEUgd94ks649bduDbzaCcrXun08xBEoR hOHwutnS068cgF8vQbwRwOQ= X-Google-Smtp-Source: AMsMyM7AISt8bws0HoEPBR1MTz2/m6UGhR0lzZ0tm7+1OJKl6QmR7yOlGw9Tp8pchRHAGJJhykDJTQ== X-Received: by 2002:a05:600c:5127:b0:3c6:47ff:5d33 with SMTP id o39-20020a05600c512700b003c647ff5d33mr22922237wms.68.1666606669564; Mon, 24 Oct 2022 03:17:49 -0700 (PDT) Received: from [192.168.9.42] ([54.239.6.188]) by smtp.gmail.com with ESMTPSA id j5-20020a05600c488500b003c6c4639ac6sm10114696wmp.34.2022.10.24.03.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 03:17:49 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 12:17:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: Patch proposal: make use of regular expressions for the username in pg_hba.conf To: Michael Paquier Cc: Tom Lane , Jacob Champion , PostgreSQL Hackers References: <607af3c9-e45d-3941-41a2-d21065d6594b@gmail.com> <6a6977ac-e4d5-5ac4-8cfb-453248946e0a@gmail.com> Content-Language: en-US From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 10/24/22 5:34 AM, Michael Paquier wrote: > On Fri, Oct 21, 2022 at 02:10:37PM +0200, Drouvot, Bertrand wrote: >> On 10/21/22 2:58 AM, Michael Paquier wrote: > > I have spent a couple of hours doing a pass over v2, playing manually > with regex patterns, reloads, the system views and item lists. The > logic was fine, but I have adjusted a few things related to the > comments and the documentation (particularly with the examples, > removing one example and updating one with a regex that has a comma, > needing double quotes). The CI and all my machines were green, and > the test coverage looked sufficient. So, applied. Thanks! Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com