Feedback-ID: ie0a040ee:Fastmail
Message-ID: <d59d7cea-fe4a-411d-a63c-2f871cb68a51@eisentraut.org>
Date: Thu, 14 Mar 2024 12:07:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: UUID v7
Content-Language: en-US
To: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Cc: Sergey Prokhorenko <sergeyprokhorenko@yahoo.com.au>,
 Jelte Fennema-Nio <postgres@jeltef.nl>,
 pgsql-hackers mailing list <pgsql-hackers@postgresql.org>,
 Aleksander Alekseev <aleksander@timescale.com>,
 =?UTF-8?Q?Przemys=C5=82aw_Sztoch?= <przemyslaw@sztoch.pl>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
 Mat Arye <mat@timescaledb.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Nikolay Samokhvalov <samokhvalov@gmail.com>, Junwang Zhao <zhjwpku@gmail.com>
References: <CAAhFRxitJv=yoGnXUgeLB_O+M7J2BJAmb5jqAT9gZ3bij3uLDA@mail.gmail.com>
 <B4034B63-6C3F-46B1-A26F-23B4B8CC72D6@yandex-team.ru>
 <0A0D7507-C434-46AC-BCC4-1166C5A2742A@yandex-team.ru>
 <CAM527d__3qQxvpUC_5tWW5TeodE=bivYT3eNDpjrVAk3-uU0TA@mail.gmail.com>
 <1459150585.359059.1706132985954@mail.yahoo.com>
 <CAM527d8QbYa9CfsUezn_owUP8M0JWGYiosMEOkQqD6=PsncEnA@mail.gmail.com>
 <00B784AB-5B52-4CC7-8A0D-B1C0C53B52DC@yandex-team.ru>
 <1014147035.642629.1706202245918@mail.yahoo.com>
 <5932FFF8-4E5F-44DC-8FEA-22E8302759C7@yandex-team.ru>
 <CAGECzQTVi1JUE43uisQ+uKz46bQ+e+uwR9PUsmNfo2rjKaqwoA@mail.gmail.com>
 <8AA22330-7D3A-46CF-B311-2FF874D7C713@yandex-team.ru>
 <1971811009.2132347.1706599708209@mail.yahoo.com>
 <72C1E7CB-E2EC-46CF-AD2C-B3180CED885B@yandex-team.ru>
 <CAEG8a3JUgkY3EMp393kJ+bcye8q=VHfQDTQz7Ci-moNVjhPLZA@mail.gmail.com>
 <0906F8BA-CA52-4956-AA68-E9193E50DFDF@yandex-team.ru>
 <10553e4c-6b66-44b9-86a7-80bb1958a767@eisentraut.org>
 <BFDA918D-1CB0-4980-A31F-C1AC95BE68F6@yandex-team.ru>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <BFDA918D-1CB0-4980-A31F-C1AC95BE68F6@yandex-team.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/d59d7cea-fe4a-411d-a63c-2f871cb68a51%40eisentraut.org>
Precedence: bulk

On 10.03.24 13:59, Andrey M. Borodin wrote:
>> The functions uuid_extract_ver and uuid_extract_var could be named
>> uuid_extract_version and uuid_extract_variant.  Otherwise, it's hard
>> to tell them apart, with only one letter different.
> 
> Renamed.

Another related comment: Throughout your patch, swap the order of 
uuid_extract_variant and uuid_extract_version.  First, this makes more 
sense because version is subordinate to variant, and also it makes it 
alphabetical.

>> I think the behavior of uuid_extract_var(iant) is wrong.  The code
>> takes just two bits to return, but the draft document is quite clear
>> that the variant is 4 bits (see Table 1).
> 
> Well, it was correct only for implemented variant. I've made version that implements full table 1 from section 4.1.

I think we are still interpreting this differently.  I think 
uuid_extract_variant should just return whatever is in those four bits. 
Your function comment says "Can return only 0, 0b10, 0b110 and 0b111.", 
which I don't think it is correct.  It should return 0 through 15.

>> I would have expected that, since gettimeofday() provides microsecond
>> precision, we'd put the extra precision into "rand_a" as per Section 6.2 method 3.
> 
> I had chosen method 2 over method 3 as most portable. Can we be sure how many bits (after reading milliseconds) are there across different OSes?

I think this should have been researched.  If we don't know how many 
bits we have, how do we know we have enough for milliseconds?  I think 
we should at least have some kind of idea, if we are going to have this 
conversation.