Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lRb4Y-0000WD-GL
	for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Mar 2021 13:39:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lRb4X-0008HN-DV
	for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Mar 2021 13:39:49 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1lRb4X-0008HG-4T
	for pgsql-hackers@lists.postgresql.org; Wed, 31 Mar 2021 13:39:49 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by makus.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1lRb4Q-0007Sk-7k
	for pgsql-hackers@lists.postgresql.org; Wed, 31 Mar 2021 13:39:48 +0000
Received: from [192.168.1.156] (nat03-43-2.netorn.net [188.35.130.88])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id C05D421C86D0;
	Wed, 31 Mar 2021 16:39:39 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1617197979;
	bh=tMoyOoib23GcoWUCLp9kK5g4IcfbzIGwNTSwUO0UVfg=;
	h=Subject:To:Cc:References:From:Date:In-Reply-To;
	b=gHmlgWjuAanI8r2Glj/FZ1XaX7p5/QlchKqCFQe8xKKWkTh7ih+ZyqjqR9Ht7ZK2E
	 ycxohyLg2mAb0ptyLzOT8Pdq7GnF/zCBTn6OWpzhA6WYOqXzggK1C5snqanO8S6adB
	 X6LKXTc08IMXK82uzOIkzKt0e+v+RdhcD2GCje8s=
Subject: Re: Flaky vacuum truncate test in reloptions.sql
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <87tuotr2hh.fsf@ars-thinkpad> <YGLOWsO2bV7KLvh7@paquier.xyz>
 <78aad736-c653-92fd-45ac-4482729459c6@postgrespro.ru>
 <CAD21AoB+qb-sOY2QeTnGirjh-UvFJj8eANVwQ4CV-r+t1AhxDA@mail.gmail.com>
From: Arseny Sher <a.sher@postgrespro.ru>
Message-ID: <d5dd7eaf-0ba1-a18b-1ef2-552196f36a71@postgrespro.ru>
Date: Wed, 31 Mar 2021 16:39:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: 
 <CAD21AoB+qb-sOY2QeTnGirjh-UvFJj8eANVwQ4CV-r+t1AhxDA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/d5dd7eaf-0ba1-a18b-1ef2-552196f36a71%40postgrespro.ru>
Precedence: bulk


On 3/31/21 4:17 PM, Masahiko Sawada wrote:

 > Is it better to add FREEZE to the first "VACUUM reloptions_test;" as 
well?

I don't think this matters much, as it tests the contrary and the 
probability of
successful test passing (in case of theoretical bug making vacuum to 
truncate
non-empty relation) becomes stunningly small. But adding it wouldn't hurt
either.

-- cheers, arseny