Feedback-ID: i131946ab:Fastmail
Message-ID: <d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com>
Date: Thu, 22 Sep 2022 22:00:00 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: libpq error message refactoring
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <7c0232ef-7b44-68db-599d-b327d0640a77@enterprisedb.com>
 <20220922154225.q4rtgzzsq6pd4f5x@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220922154225.q4rtgzzsq6pd4f5x@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a%40enterprisedb.com>
Precedence: bulk

On 22.09.22 17:42, Andres Freund wrote:
> This patch has been failing for a while:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3854
> 
> Interestingly, previously the error only happened when targetting windows, but
> meson also shows it on freebsd.
> 
> It's not the cause of this failure, I think, but doesn't appendPQExpBufferVA
> need to be added to exports.txt?

I don't want to make that function available to users of libpq, just use 
it inside libpq across .c files.  Is there no visibility level for that? 
  Is that also the problem in the freebsd build?