MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 12 Jul 2018 11:28:34 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, pgsql-hackers@postgresql.org, Ildus
 Kurbangaliev <i.kurbangaliev@postgrespro.ru>, Teodor Sigaev
 <teodor@sigaev.ru>
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Organization: Postgres Professional
In-Reply-To: <20180711174906.oscbjjivg6gc2riu@alvherre.pgsql>
References: <20180711174906.oscbjjivg6gc2riu@alvherre.pgsql>
Message-ID: <d63e60a8b741ea57e72b29c9efb2e2ca@postgrespro.ru>
User-Agent: Roundcube Webmail/1.2.4
Precedence: bulk

On 11-07-2018 20:49, Alvaro Herrera wrote:
> On 2018-Jul-11, Marina Polyakova wrote:
> 
>> can we try something like this?
>> 
>> PGBENCH_ERROR_START(DEBUG_FAIL)
>> {
>> 	PGBENCH_ERROR("client %d repeats the failed transaction (try %d",
>> 				  st->id, st->retries + 1);
>> 	if (max_tries)
>> 		PGBENCH_ERROR("/%d", max_tries);
>> 	if (latency_limit)
>> 	{
>> 		PGBENCH_ERROR(", %.3f%% of the maximum time of tries was used",
>> 					  getLatencyUsed(st, &now));
>> 	}
>> 	PGBENCH_ERROR(")\n");
>> }
>> PGBENCH_ERROR_END();
> 
> I didn't quite understand what these PGBENCH_ERROR() functions/macros
> are supposed to do.  Care to explain?

It is used only to print a string with the given arguments to stderr. 
Probably it might be just the function pgbench_error and not a macro..

P.S. This is my mistake, I did not think that PGBENCH_ERROR_END does not 
know the elevel for calling exit(1) if the elevel >= ERROR.

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company