Subject: Re: [POC] Fast COPY FROM command for the table with foreign
 partitions
To: Amit Langote <amitlangote09@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Etsuro Fujita <etsuro.fujita@gmail.com>,
 PostgreSQL-Dev <pgsql-hackers@postgresql.org>
References: <ae25e79e-6122-720e-1349-fb832c6021df@postgrespro.ru>
 <CA+HiwqH2ehGurL9bYUydXBxVUH6aHN5yXXxESAOs9O6-f_+Qeg@mail.gmail.com>
 <cf1e92eb-9a8e-f5c1-f0cc-598882f1e546@postgrespro.ru>
 <CA+HiwqHRqG8X9W6-v-E6d0nw1k6aC7QSMk-SOvv4puOjWsQMmA@mail.gmail.com>
 <9a65d03b-250f-b086-5a3c-541d8e2de30d@postgrespro.ru>
 <CA+HiwqE6M4mwH=CDOKmy5DUHRDP-knLdAfmCh+GW7D59s3QDRg@mail.gmail.com>
 <CA+HiwqHtQaZp_t5M3z1+M0T9zd=0s3r_oOmi9TxHDdyW0_cxvg@mail.gmail.com>
 <ab62d228-cf9a-e517-8667-7df1184adf2a@postgrespro.ru>
 <CA+HiwqG1o5BDi0Hx6Uoxteyra2FbiSvaN4Fzs-i0pfKo1Zp_fg@mail.gmail.com>
 <CA+HiwqHT9UFhVHyKsavL5u=iVdW9k92pHHN=FYL0sEysGtvYsw@mail.gmail.com>
 <20200907072651.GF4867@paquier.xyz>
 <19ba27e7-ee1e-9117-68ad-fd609b5763ca@postgrespro.ru>
 <CA+HiwqEoSMpzMhzz1Dv7qFsFtzG71t5Wrgy4F+MoVUVR_5HdDQ@mail.gmail.com>
From: "Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
Message-ID: <d6896ede-eb50-c2dd-df5a-16f767e16c57@postgrespro.ru>
Date: Tue, 8 Sep 2020 15:21:33 +0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: 
 <CA+HiwqEoSMpzMhzz1Dv7qFsFtzG71t5Wrgy4F+MoVUVR_5HdDQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/8/20 12:34 PM, Amit Langote wrote:
> Hi Andrey,
> 
> On Mon, Sep 7, 2020 at 7:31 PM Andrey V. Lepikhov
> <a.lepikhov@postgrespro.ru> wrote:
>> On 9/7/20 12:26 PM, Michael Paquier wrote:
>>> While on it, the CF bot is telling that the documentation of the patch
>>> fails to compile.  This needs to be fixed.
>>> --
>>> Michael
>>>
>> v.7 (in attachment) fixes this problem.
>> I also accepted Amit's suggestion to rename all fdwapi routines such as
>> ForeignCopyIn to *ForeignCopy.
> 
> Any thoughts on the taking out the refactoring changes out of the main
> patch as I suggested?
> 
Sorry I thought you asked to ignore your previous letter. I'll look into 
this patch set shortly.

-- 
regards,
Andrey Lepikhov
Postgres Professional