Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPN3j-0008Kc-2a for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 08:40:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPN3h-0008Hu-Qb for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Oct 2019 08:40:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPN3g-0008Hk-Tn for pgsql-hackers@lists.postgresql.org; Tue, 29 Oct 2019 08:40:57 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPN3c-0006Lj-Nc for pgsql-hackers@lists.postgresql.org; Tue, 29 Oct 2019 08:40:56 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 52AEE22095; Tue, 29 Oct 2019 04:40:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 29 Oct 2019 04:40:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WJtT8I9OFGw780IFHCzvbe0uwslEYx/Ll/eImmVOR lo=; b=Ci9BW2HwB0H8XAw1JjLOUMyKPpzH39NIWktzkuK9VXaxKWDzUjyXvk5uR Wxx823Rg2cMX8CLIYgSqdtvGdPoNDcIwpu4xwBt1AuKFmevUKii7ow15ViTvoJIg pMfDFGbZfKah7Kv5qiZSohL4SQuSorpYDpaJqMUJsqKUu533Nqyy2WpAG7STIrM0 taWWYmm9SRR6aXpk0ptvj4yb+70yUTNMutzGr8K/mez+kCebmyDz3emqBjdJ9Iae kKgkRuwfh12J75xZfbZ3Wp8Lx6HHrPlLSyNcYsBoe1lmHTtz1iTJM69My/eofJoe eFcHOzr4iUaIah4KqI/ERjC3f825A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddttddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhfhokffffgggjggtgfesthejredttdefjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsedvnh guqhhurggurhgrnhhtrdgtohhmqeenucffohhmrghinhepvdhnughquhgrughrrghnthdr tghomhenucfkphepleefrddvgedvrddugeejrdejleenucfrrghrrghmpehmrghilhhfrh homhepphgvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqhhurggurhgrnhhtrdgtohhm necuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from april.pezone.net (p5df2934f.dip0.t-ipconnect.de [93.242.147.79]) by mail.messagingengine.com (Postfix) with ESMTPA id 65CAED6005A; Tue, 29 Oct 2019 04:40:49 -0400 (EDT) Subject: Re: MinGW compiler warnings in ecpg tests To: Michael Meskes , pgsql-hackers@lists.postgresql.org References: <760c9dd1-2d80-c223-3f90-609b615f7918@2ndquadrant.com> <127d468dd80c7b1b4c616e111431faf60e091697.camel@postgresql.org> From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Tue, 29 Oct 2019 09:40:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <127d468dd80c7b1b4c616e111431faf60e091697.camel@postgresql.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-10-26 10:40, Michael Meskes wrote: >> These files don't use our printf replacement or the c.h porting >> layer, >> so unless we want to start doing that, I propose the attached patch >> to >> determine the appropriate format conversion the hard way. > > I don't think such porting efforts are worth it for a single test case, > or in other words, if you ask me go ahead with your patch. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services