Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erwbN-00056V-KL for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Mar 2018 02:08:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erwbL-0004NI-Mk for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Mar 2018 02:08:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erwbL-0004N8-Fa for pgsql-hackers@lists.postgresql.org; Sat, 03 Mar 2018 02:08:43 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erwb3-0002wZ-Nq for pgsql-hackers@postgresql.org; Sat, 03 Mar 2018 02:08:43 +0000 Received: from Davids-iMac.local (unknown [173.169.74.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 80A8054668; Sat, 3 Mar 2018 02:08:23 +0000 (UTC) Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions To: Tomas Vondra , Andres Freund Cc: Peter Eisentraut , PostgreSQL Hackers References: <5d00346a-b565-7fde-c6da-35f39c72936a@2ndquadrant.com> <4d7ed7b8-df43-9b79-b04e-ad4c43ef519c@2ndquadrant.com> <20180302011235.k7bxqmktrvgz5tpb@alap3.anarazel.de> <90964101-eef1-68b1-a337-5e5d4bd6e7f0@pgmasters.net> <20180302200529.fwiquub5cr3o4gpz@alap3.anarazel.de> <20180303010153.myd3f2bcdvqo6ry5@alap3.anarazel.de> <47ffe720-8255-923d-78fc-a7c4e9011a42@2ndquadrant.com> From: David Steele Message-ID: Date: Fri, 2 Mar 2018 21:08:22 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <47ffe720-8255-923d-78fc-a7c4e9011a42@2ndquadrant.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 3/2/18 8:54 PM, Tomas Vondra wrote: > On 03/03/2018 02:37 AM, David Steele wrote: >> On 3/2/18 8:01 PM, Andres Freund wrote: >>> On 2018-03-03 02:00:46 +0100, Tomas Vondra wrote: >>>> That is somewhat misleading, I think. You're right the last version was >>>> submitted on 2018-01-19, but the next review arrived on 2018-01-31, i.e. >>>> right at the end of the CF. So it's not like the patch was sitting there >>>> with unresolved issues. Based on that review the patch was marked as RWF >>>> and thus not moved to 2018-03 automatically. >>> >>> I don't see how this changes anything. >> >> I agree that things could be clearer, and Andres has produced a great >> document that we can build on. The old one had gotten a bit stale. >> >> However, I think it's pretty obvious that a CF entry should be >> accompanied with a patch. It sounds like the timing was awkward but >> you still had 28 days to produce a new patch. > > Based on internal discussion I'm not so sure about the "pretty obvious" > part. It certainly wasn't that obvious to me, otherwise I'd submit the > revised patch earlier - hindsight is 20/20. Indeed it is. Be assured that nobody takes pleasure in pushing patches, but we have limited resources and must make some choices. >> I also notice that you submitted 7 patches in this CF but are >> reviewing zero. > > I've volunteered to review a couple of patches at the FOSDEM Developer > Meeting - I thought Stephen was entering that into the CF app, not sure > where it got lost. There are plenty of patches that need review, so go for it. Regards, -- -David david@pgmasters.net