Message-ID: <d709fac2-adac-4a1e-a33c-028549137a3c@dalibo.com>
Date: Wed, 26 Nov 2025 21:02:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: oid2name : add objects file path
To: pgsql-hackers@lists.postgresql.org
References: 
 <CABour1v2CU1wjjoM86wAFyezJQ3-+ncH43zY1f1uXeVojVN8Ow@mail.gmail.com>
 <907f85f4-ca62-438e-9dcc-33d551d29969@app.fastmail.com>
 <CABour1s9hhx508E51=pCJ6W7s0t=ywkBWoseRe9FW-=NNHwZRQ@mail.gmail.com>
Content-Language: fr
From: Guillaume Lelarge <guillaume.lelarge@dalibo.com>
Organization: Dalibo
In-Reply-To: 
 <CABour1s9hhx508E51=pCJ6W7s0t=ywkBWoseRe9FW-=NNHwZRQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/d709fac2-adac-4a1e-a33c-028549137a3c%40dalibo.com>
Precedence: bulk

Hi David,

I just looked at the commit fest entry and the bot says your patch needs=20
a rebase. Can you do it? Thanks.

Regards.

On 08/10/2025 14:44, David Bidoc wrote:
> On Tue, Oct 7, 2025 at 11:47=E2=80=AFAM Euler Taveira <euler@eulerto.co=
m> wrote:
>=20
>> 1. The database query is wrong because it is considering that all data=
bases are
>> in the default tablespace. If you create a database in a different tab=
lespace
>> you will notice the mistake.
>=20
> Thank you for your feedback.
>=20
> Indeed, the path is wrong if the default tablespace is not used.
> I did not find a simple way to retrieve the database path (to my
> knowledge there is
> no function like pg_database_location() or something similar), so I hav=
e removed
> this part from the patch for now.
>=20
>>
>> 2. I suggest that you change one of the examples (maybe the last one) =
to
>> illustrate this feature.
>=20
> Here is a new example by adding a table in a different tablespace :
>=20
> $ oid2name -p 5435 -d b1 -t t2 -x
>  From database "b1":
>    Filenode  Table Name    Oid  Schema  Tablespace
>                 Filepath
> -----------------------------------------------------------------------=
-----------------------
>       16403          t2  16403  public     tblspc1
> pg_tblspc/16393/PG_19_202510082/16384/16403
>=20
>=20
>> Since you are in this area, you could create a separate patch for show=
 the
>> tablespace location (-s option). Use pg_tablespace_location function.
>>
> I attached a new patch to add a column Tablespace Location to the -s op=
tion.
>=20
> $ oid2name -p 5435 -s
> All tablespaces:
>      Oid  Tablespace Name  Tablespace Location
> ---------------------------------------------
>     1663       pg_default
>     1664        pg_global
>    16393          tblspc1      /mnt/tblspc1/pg
>=20
>> Register your patch for the next commitfest so we don't lose track of =
it. [1]
>> If you don't have an account, the 'Log In' link will redirect you to t=
he page
>> to create a new one or even allow you to use a third party sign in.
>>
>> [1] https://commitfest.postgresql.org/56/
>>
>=20
> Done.
> https://commitfest.postgresql.org/patch/6111/
>=20
> Regards
> David Bidoc


--=20
Guillaume Lelarge
Consultant
https://dalibo.com