Feedback-ID: i131946ab:Fastmail
Message-ID: <d737e3b0-1a02-c0b7-4a51-8b16eacaba24@enterprisedb.com>
Date: Wed, 7 Jun 2023 17:03:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.0
Subject: Re: Order changes in PG16 since ICU introduction
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Sandro Santilli <strk@kbt.io>, Tom Lane <tgl@sss.pgh.pa.us>,
 Regina Obe <lr@pcorp.us>, pgsql-hackers@lists.postgresql.org
References: <20230509082553.yjikrxn54mi6hezc@alvherre.pgsql>
 <05ad2b39-3d0f-e0aa-e0a3-086b998a26e8@enterprisedb.com>
 <0b93be9554c21abfe9571ea9243fa5aa196d9200.camel@j-davis.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <0b93be9554c21abfe9571ea9243fa5aa196d9200.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d737e3b0-1a02-c0b7-4a51-8b16eacaba24%40enterprisedb.com>
Precedence: bulk

On 22.05.23 19:35, Jeff Davis wrote:
> On Thu, 2023-05-11 at 13:07 +0200, Peter Eisentraut wrote:
>> Here is my proposed patch for this.
> 
> The commit message makes it sound like lc_collate/ctype are completely
> obsolete, and I don't think that's quite right: they still represent
> the server environment, which does still matter in some cases.
> 
> I'd just say that they are too confusing (likely to be misused), and
> becoming obsolete (or less relevant), or something along those lines.
> 
> Otherwise, this is fine with me. I didn't do a detailed review because
> it's just mechanical.

I have committed this with some tuning of the commit message.