Message-ID: <d7399b1f-a59b-4ff3-b3ac-f82439e3f261@dunslane.net>
Date: Sun, 4 Aug 2024 10:12:29 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Official devcontainer config
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Andrey Borodin <amborodin86@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
References: <CAEG8a3K_mZsBZ60smh4FM4Dk9cazAUmM72iXdFKEHgthZnaHcw@mail.gmail.com>
 <57c12c52-123c-4a13-a258-02639473fa17@dunslane.net>
 <dfd66b40-4b8d-4239-bbca-01d3e431ca5b@eisentraut.org>
 <f1ab7b6f-2a22-41ff-bcc0-885bd65e550d@dunslane.net>
 <CAEG8a3L6Bhk=6p9k7REG193Wfp_Sxfo3SjAwuyG10Z04dWCTdg@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <CAEG8a3L6Bhk=6p9k7REG193Wfp_Sxfo3SjAwuyG10Z04dWCTdg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/d7399b1f-a59b-4ff3-b3ac-f82439e3f261%40dunslane.net>
Precedence: bulk


On 2024-08-03 Sa 10:13 PM, Junwang Zhao wrote:
> On Sat, Aug 3, 2024 at 7:30 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>>
>> On 2024-08-02 Fr 2:45 PM, Peter Eisentraut wrote:
>>> On 01.08.24 23:38, Andrew Dunstan wrote:
>>>> Not totally opposed, and I will probably give it a try very soon, but
>>>> I'm wondering if this really needs to go in the core repo. We've
>>>> generally shied away from doing much in the way of editor / devenv
>>>> support, trying to be fairly agnostic. It's true we carry
>>>> .dir-locals.el and .editorconfig, so that's not entirely true, but
>>>> those are really just about supporting our indentation etc. standards.
>>> Yeah, the editor support in the tree ought to be minimal and factual,
>>> based on coding standards and widely recognized best practices, not a
>>> collection of one person's favorite aliases and scripts.  If the
>>> scripts are good, let's look at them and maybe put them under
>>> src/tools/ for everyone to use.  But a lot of this looks like it will
>>> requite active maintenance if output formats or node formats or build
>>> targets etc. change.  And other things require specific local paths.
>>> That's fine for a local script or something, but not for a mainline
>>> tool that the community will need to maintain.
>>>
>>> I suggest to start with a very minimal configuration. What are the
>>> settings that absolute everyone will need, maybe to set indentation
>>> style or something.
>>>
>> I believe you can get VS Code to support editorconfig, so from that POV
>> maybe we don't need to do anything.
>>
>> I did try yesterday with the code from the OP's patch symlinked into my
>> repo, but got an error with the Docker build, which kinda reinforces
>> your point.
> The reason symlink does not work is that configure_vscode needs to copy
> launch.json and tasks.json into .vscode, it has to be in the
> WORKDIR/.devcontainer.


That's kind of awful. Anyway, I think we don't need to do anything about 
ignoring those. The user should simply add entries for them to 
.git/info/exclude or their local global exclude file (I have 
core.excludesfile = /home/andrew/.gitignore set.)

I was eventually able to get it to work without using a symlink.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com