Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtbpJ-00049v-ED for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2020 19:03:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jtbpI-0005CF-Ef for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2020 19:03:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtbpI-0005C7-60 for pgsql-hackers@lists.postgresql.org; Thu, 09 Jul 2020 19:03:20 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jtbpF-0007ad-Hs for pgsql-hackers@postgresql.org; Thu, 09 Jul 2020 19:03:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YOgMfKKwdDXPyOWJ2qtCke1WcgiJD8iXiQlWjQXiu0U=; b=Kcr5dsN2+EBzCdwTbecRGlGY3h vTKO646n9wTUNd7fS2AZs0mN0R26w2/PNz7ED5GHhnH+By/Izhi3BEz2s4pQNPmKQfhr8TgNMdd+/ twwt3qqk/4AltOvijjj/Dr5Cib4imU3DW96bo765a8EqgordW+Q4pgn9qaYoHGhsapwOLtBwyiAPC xLi+IX//1c6Lny61/WPYZkm1O3qiPX8NprqKU5DZLhoXiJoY9Jsx8Np0+T93bydTmkB+HHJS8Yuop CxfNgQsizn/ekWsotWPJmOYwXLi0wDnR/CM3vyQhD4Sti68Tt/8dEFFR1BJ4PggOFUUlxL87rUqaD 8Y8AYuXg==; Received: from pool-173-56-10-231.nycmny.fios.verizon.net ([173.56.10.231] helo=Ph33rHippo.local) by meldrar.postgresql.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jtbpD-0005AX-58; Thu, 09 Jul 2020 19:03:17 +0000 Subject: Re: output columns of \dAo and \dAp To: Alexander Korotkov , Tom Lane Cc: Peter Eisentraut , pgsql-hackers References: <2edc7b27-031f-b2b6-0db2-864241c91cb9@2ndquadrant.com> <1698998.1591479248@sss.pgh.pa.us> From: "Jonathan S. Katz" Autocrypt: addr=jkatz@postgresql.org; keydata= mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC Message-ID: Date: Thu, 9 Jul 2020 15:03:11 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d2Lj3pJNjp5Lx97xBNioaG143vtvJwh7e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d2Lj3pJNjp5Lx97xBNioaG143vtvJwh7e Content-Type: multipart/mixed; boundary="qMFvHgJwbzi6f5F1saGIO6ToZZIXfrVRm"; protected-headers="v1" From: "Jonathan S. Katz" To: Alexander Korotkov , Tom Lane Cc: Peter Eisentraut , pgsql-hackers Message-ID: Subject: Re: output columns of \dAo and \dAp References: <2edc7b27-031f-b2b6-0db2-864241c91cb9@2ndquadrant.com> <1698998.1591479248@sss.pgh.pa.us> In-Reply-To: --qMFvHgJwbzi6f5F1saGIO6ToZZIXfrVRm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/7/20 6:09 PM, Alexander Korotkov wrote: > On Sun, Jun 7, 2020 at 12:34 AM Tom Lane wrote: >> Peter Eisentraut writes: >>> I'm also wondering whether this is fully correct. Would it be possib= le for the >>> argument types of the operator/function to differ from the left arg/r= ight arg >>> types? (Perhaps binary compatible?) >> >> pg_amop.h specifies that >> >> * The primary key for this table is > * amopstrategy>. amoplefttype and amoprighttype are just copies of t= he >> * operator's oprleft/oprright, ie its declared input data types. >> >> Perhaps it'd be a good idea for opr_sanity.sql to verify that, since >> it'd be an easy thing to mess up in handmade pg_amop entries. But >> at least for the foreseeable future, there's no reason for \dAo to sho= w >> amoplefttype/amoprighttype separately. >=20 > +1 for checking consistency of amoplefttype/amoprighttype in opr_sanity= =2Esql >=20 >> I agree that \dAo ought to be showing amopstrategy; >=20 > I agree that the strategy and purpose of an operator is valuable > information. And we probably shouldn't hide it in \dAo. If we do so, > then \dAo and \dAo+ differ by only "sort opfamily" column. Is it > worth keeping the \dAo+ command for single-column difference? >=20 >> moreover that ought >> to be much higher in the sort key than it is. >=20 > Do you mean we should sort by strategy number and only then by > arg types? Current output shows operators grouped by opclasses, > after that cross-opclass operators are shown. This order seems to me > more worthwhile than seeing all the variations of the same strategy > together. >=20 >> Also, if we're not going >> to show amoppurpose, then the view probably ought to hide non-search >> operators altogether. It is REALLY misleading to not distinguish sear= ch >> and ordering operators. >=20 > +1 >=20 >> The situation is different for pg_amproc: if you look for discrepancie= s >> you will find plenty, since in many cases a support function's signatu= re >> has little to do with what types it is registered under. Perhaps it'd= be >> worthwhile for \dAp to show the functions as regprocedure in addition = to >> showing amproclefttype/amprocrighttype explicitly. In any case, I thi= nk >> it's rather misleading for \dAp to label amproclefttype/amprocrighttyp= e as >> "Left arg type" and "Right arg type", because for almost everything ex= cept >> btree/hash, that's not what the support function's arguments actually = are. >> Perhaps names along the lines of "Registered left type" and "Registere= d >> right type" would put readers in a better frame of mind to understand >> the entries. >=20 > +1 for rename "Left arg type"/"Right arg type" to "Registered left > type"/"Registered right type". =46rom the RMT perspective, if there is an agreed upon approach (which it= sounds like from the above) can someone please commit to working on resolving this open item? Thanks! Jonathan --qMFvHgJwbzi6f5F1saGIO6ToZZIXfrVRm-- --d2Lj3pJNjp5Lx97xBNioaG143vtvJwh7e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAl8Hae8ACgkQ8QSccp8c ZSffqQ/6A67rukhuAu4YubGSyk0QciWTzer4+e5alwv/VOMD5vR0jH3vGlAoc6Wq Ioy7iIT2KOI061bvOzI5/Iz0Q26r5j1EBG1kYJ8gyZo7o6dmVeaHswgrSVgPBh/j 1/npdsQl/MBB0qzDIjaI6t/S3AMhp0itLyufLQ6l8RSo8/gdHRrrLw95pSAc10es MCMqa8owkljWT1nHlRHe/lgLYzkPf2wKN7dpqhTG+1FOcLT33QZICXXr6CldQP8z nqnVdVw1ltHZYH4q3/G84+NBnIriH6CbUEP4OCTpJp76D+uGIvi2fSVJAnkf+kTm W8BsrKBdQm3/WAS11TD4+s5HKQUlDWZLrAuJ+jAGczCbwcPX9ipLhGjP0ssv9O9u b270eqYc2+pF2s7B4F5gGuyGctJtT/iwD/tFrVese+W5/oKGbAktifBHXlzeu1+k mMp7BBX38VMF/sexROc4gsDqd70bmVAlVnbY8Tnp8zuJlleCPPxskOnYbzoPnkJC d4QezAqQ03D3UGx0k2UG+7QZalKvy5EqEsN8Oijq2ItYBmhSmLrJI/UbEC/BmqEA JCuj9k6piamsVB/PV9uBEXdw0nIrbR1ynis8Ew5rn4QszFXukMp8eFq671SHH+DT zT8XOsQso5i1cXgQtR8hCaFPyLoStPt7YrL5J1/C6cqBduKy1ek= =b1F0 -----END PGP SIGNATURE----- --d2Lj3pJNjp5Lx97xBNioaG143vtvJwh7e--