Message-ID: <d7a03664-bef5-49b0-998f-3ea5356b53c9@oss.nttdata.com>
Date: Tue, 12 Nov 2024 01:49:34 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add reject_limit option to file_fdw
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
References: <bab68a9fc502b12693f0755b6f35f327@oss.nttdata.com>
 <fd14c3a0-a036-4bce-b5f8-4af83259eae1@oss.nttdata.com>
 <54747389a562688eab7077b144daff6a@oss.nttdata.com>
 <2b3ad6d4-e05f-4188-8cfe-1fd9d949a9c9@oss.nttdata.com>
 <192ede1e4c2b34b853e5ac46f8dee50b@oss.nttdata.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <192ede1e4c2b34b853e5ac46f8dee50b@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d7a03664-bef5-49b0-998f-3ea5356b53c9%40oss.nttdata.com>
Precedence: bulk


On 2024/11/11 21:45, torikoshia wrote:
>> Thanks for adding the comment. It clearly states that REJECT_LIMIT can be
>> a single-quoted string. However, it might also be helpful to mention that
>> it can be provided as an int64 in the COPY command option. How about
>> updating it like this?
>>
>> ------------------------------------
>> REJECT_LIMIT can be specified in two ways: as an int64 for the COPY command
>> option or as a single-quoted string for the foreign table option using
>> file_fdw. Therefore this function needs to handle both formats.
>> ------------------------------------
> 
> Thanks! it seems better.
> 
> 
> Attached v3 patch.

Thanks for updating the patch! It looks like you forgot to attach it, though.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION