Message-ID: <d7d0315b35a5f71660b1b40fa1f5c3194d78dad8.camel@cybertec.at>
Subject: Re: System views for versions reporting
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, jian he <jian.universality@gmail.com>, Joe
 Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org
Date: Wed, 26 Nov 2025 14:28:06 +0100
In-Reply-To: <xzbehdw5d7caffbvwfjhrmmqigmrha2qx7krshoivbr7dgcjd6@5enodmbfc5sz>
References: <e4eb427c-0aea-4821-8940-eb5d949233dd@joeconway.com>
	 <tbbg5xlg46w4us4siwqa7v4y6lbr67hojjg5xgagwihrbsceh5@nfw62fdocrbc>
	 <5jhyl6p3nwcaxczfxuh25q42q6bqlaxyqyfqtw4tldvmm24bw2@rfii5tkwn5rg>
	 <CACJufxFD7ra6-HYmksJPMrY8Q036HA6EFyrUjrOPiq8CrfkGvg@mail.gmail.com>
	 <burlbnmi2a2mxt33migp3m3pqglgtat3axak2prmhiwhwuljxv@7ea4hlniydvk>
	 <866452.1742768493@sss.pgh.pa.us>
	 <yewkpc65y5g6fjd3kge2jetge3q2625hz64mietmyoczhqkmpu@ltotskxk4ndk>
	 <vyejydf4qnamuyz4slawjqzuhl3kgzfzgrtruwiuse2v6xitaa@ejvkxapdvqh5>
	 <a7d6f24f338149a0abfe058d7f5be5bbf4a7cd67.camel@cybertec.at>
	 <jx5ozoohe653lf2f7p4j65b76pikqymdunpopjkeznfdzwgokv@bt43jrh226ee>
	 <xzbehdw5d7caffbvwfjhrmmqigmrha2qx7krshoivbr7dgcjd6@5enodmbfc5sz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/d7d0315b35a5f71660b1b40fa1f5c3194d78dad8.camel%40cybertec.at>
Precedence: bulk

On Tue, 2025-11-25 at 16:40 +0100, Dmitry Dolgov wrote:
> Here is the updated patch.

Thanks for the updated patch.

Comments:

You didn't address any of my suggestions concerning the documentation,
except that you moved the entry in "System Views" to the correct place.

The second patch contains:

> +void
> +jit_register_version(void)
> +{
> +   add_system_version("LLVM", jit_get_version, RunTime);
> +}

But that belongs into the third patch.

+/*
+ * Callback for add_system_version, returns JIT provider's version string =
and
+ * reports if it's not available.
+ */
+const char *
+jit_get_version(bool *available)
+{
+   const char *version;
+
+   if (!provider_init())
+   {
+       *available =3D false;
+       return "";
+   }
+
+   version =3D provider.get_version();
+
+   if (version =3D=3D NULL)
+   {
+       *available =3D false;
+       return "";
+   }
+
+   *available =3D true;
+   return version;
+}

Perhaps more elegant would be:

    if (provider_init())
    {
        version =3D provider.get_version();
        if (version)
        {
            *available =3D true;
            return version;
        }
    }

    *available =3D false;
    return "";

Other than that, it looks fine.

Yours,
Laurenz Albe