Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyf7-00048G-Om for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 02:50:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkyf5-0008Jz-RQ for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Apr 2023 02:50:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkyf5-0008Jq-I1 for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 02:50:43 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pkyf2-001Yio-5j for pgsql-hackers@lists.postgresql.org; Sat, 08 Apr 2023 02:50:43 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id C6714100002; Sat, 8 Apr 2023 02:50:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------wWHwOUmMzcvEnAiTVsZot37c" Message-ID: Date: Fri, 7 Apr 2023 22:50:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: daitch_mokotoff module Content-Language: en-US To: Tom Lane , Dag Lem Cc: Tomas Vondra , Andres Freund , Alvaro Herrera , Paul Ramsey , PostgreSQL Hackers References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> <3135273.1680893728@sss.pgh.pa.us> <3271512.1680916423@sss.pgh.pa.us> <3278776.1680918752@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <3278776.1680918752@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------wWHwOUmMzcvEnAiTVsZot37c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-04-07 Fr 21:52, Tom Lane wrote: > I wrote: >> I pushed this after some mostly-cosmetic fiddling. Most of the >> buildfarm seems okay with it, > Spoke too soon [1]: > > make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch' > '/usr/bin/perl' daitch_mokotoff_header.pl daitch_mokotoff.h > Can't locate open.pm in @INC (you may need to install the open module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at daitch_mokotoff_header.pl line 15. > BEGIN failed--compilation aborted at daitch_mokotoff_header.pl line 15. > make[1]: *** [Makefile:33: daitch_mokotoff.h] Error 2 > > pipit appears to be running a reasonably current system (RHEL8), so > the claim that "open" is a Perl core module appears false. We need > to rewrite this to not use that. > > regards, tom lane > > [1]https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pipit&dt=2023-04-08%2001%3A02%3A39 > > I think it is a core module (See ) but it appears that some packagers have separated it out for reasons that aren't entirely obvious: andrew@emma:~ $ rpm -q -l -f /usr/share/perl5/open.pm /usr/share/man/man3/open.3pm.gz /usr/share/perl5/open.pm cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------wWHwOUmMzcvEnAiTVsZot37c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2023-04-07 Fr 21:52, Tom Lane wrote:
I wrote:
I pushed this after some mostly-cosmetic fiddling.  Most of the
buildfarm seems okay with it,
Spoke too soon [1]:

make[1]: Entering directory '/home/linux1/build-farm-16-pipit/buildroot/HEAD/pgsql.build/contrib/fuzzystrmatch'
'/usr/bin/perl' daitch_mokotoff_header.pl daitch_mokotoff.h
Can't locate open.pm in @INC (you may need to install the open module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at daitch_mokotoff_header.pl line 15.
BEGIN failed--compilation aborted at daitch_mokotoff_header.pl line 15.
make[1]: *** [Makefile:33: daitch_mokotoff.h] Error 2

pipit appears to be running a reasonably current system (RHEL8), so
the claim that "open" is a Perl core module appears false.  We need
to rewrite this to not use that.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pipit&dt=2023-04-08%2001%3A02%3A39



I think it is a core module (See <https://metacpan.org/pod/open>) but it appears that some packagers have separated it out for reasons that aren't entirely obvious:

andrew@emma:~ $ rpm -q -l -f /usr/share/perl5/open.pm
/usr/share/man/man3/open.3pm.gz
/usr/share/perl5/open.pm

cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------wWHwOUmMzcvEnAiTVsZot37c--