Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc6e8-0002R7-UT for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 15:33:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pc6e7-0000ns-Lm for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 15:33:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc6e7-0000mr-BH for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 15:33:03 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pc6e4-0005oi-6a for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 15:33:02 +0000 Received: by mail-ed1-x529.google.com with SMTP id y4so34207252edo.2 for ; Tue, 14 Mar 2023 08:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1678807979; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4uclGcIHbMhTZQ8WlnkkSnoXBnPGaviyseKx8VFYDDI=; b=lHNXAvC1AlDXoqYBGoGhJD8yyrMcCknen1FRbYHGK9K9UD8cqJlZ2NHm9RjRaylFXq 0E4Sy+6Sm7S/Y8JnDSRWbarXd12N66OCcn4Iz66uHnvSEJoGd8m6oL3yQGEtwvUQFv8S BOU+QJtxnqfqWgjTd8bedOogOoz6PhxqOerBgq0uiktcPypyDcBgSMifhkiknLEtCe/S Smy8vcZFY9OSlpGLBrr5Lm28qXhUN7IrSGITE85CrAop1YaVhqK3oDCCaUjimMx7GTPu 1K8o3YFj7HNlndxMMzYG2LfgUCXEYnBt7sNgPQXTqNX8T1dTIaATxD0hA8IQRpdjC+V4 daQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678807979; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4uclGcIHbMhTZQ8WlnkkSnoXBnPGaviyseKx8VFYDDI=; b=jj1uM/wYyeLLpYET/zIapAdsGPcHoyjgh6zGJvqy1mr4abhD5VwA3c053Gk5P6rm/O TscNVoZYrHmW9TZ7HYrKa08RihcKJqVesKJNrMrmbv2Y3cBMxV408SZjmnJe/wQfOq+L TEGgTg5IayD6wsYCnZsqu51t+kbf/rnm8KgvjUojXQj4qKsXnxBBq5NTFkDkUr7XMx6c +zuKAquYF98JlSE343P4EQSOwTJOnLKH6Z26TeZeSP1CVm7ex+EgVbejvO4d7po4roKW D9v1G4/rk/j3ahYUtrFDjAP5t21WaHwykEE+nyopZYwwB4y97IAXGZVNe8+b/Dhjcn8w z7Dg== X-Gm-Message-State: AO0yUKVYwC9vtJR49a5iq22L34ii/Kaa2yr9KRMuLQk08IgeQIyHW1mQ Y3e/4g7ufTNwbBIJb584SyORUlcDizJpVdgsqUBameXdvocdb6Zld7B9LeEPkGwJUVRUsOT2jcZ PpjGa+tfTERPLVA0MIsAK1qVUg4MLKqPARaWD3AKnA+ehF3k6n9CSm42TgopaQxq7tXZrzgw3ks 8cphbZbpqS9UF4/7drJxu1Cko7noAWVaXvYY4mtBMKFTp1N71A4g2f X-Google-Smtp-Source: AK7set+QdfHj/rxkum+MsAd0rq8yrZzoqoLvt8k07m3sifbDzbwcFVnMawosDalPBumK7T14JaqUSg== X-Received: by 2002:a17:906:f914:b0:88c:6345:d0e7 with SMTP id lc20-20020a170906f91400b0088c6345d0e7mr2891777ejb.36.1678807979181; Tue, 14 Mar 2023 08:32:59 -0700 (PDT) Received: from [10.137.0.17] (ip-86-49-228-162.bb.vodafone.cz. [86.49.228.162]) by smtp.gmail.com with ESMTPSA id si2-20020a170906cec200b008e68d2c11d8sm1276883ejb.218.2023.03.14.08.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 08:32:58 -0700 (PDT) Message-ID: Date: Tue, 14 Mar 2023 16:32:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Add LZ4 compression in pg_dump Content-Language: en-US To: gkokolatos@pm.me Cc: Alexander Lakhin , "shiy.fnst@fujitsu.com" , Michael Paquier , Justin Pryzby , "pgsql-hackers@lists.postgresql.org" , Rachel Heaton References: <7zu6GYFi72jByVk2SEe_nd8r1DHhwA35vSntAE9sAfiMX9Lfk6bwimkwmu7GDgYaEvL27SE4qF1uK4_LHWQM4H-SXOwkMAI-GV8PKGmED_E=@pm.me> <535565cd-b69f-c064-a845-15c0fc44db4a@enterprisedb.com> <22cb80ed-ec87-54c7-fd5b-cdcf79766bb1@enterprisedb.com> <8421f53d-c9f7-c02e-3278-9f9522a8e8f3@enterprisedb.com> <33496f7c-3449-1426-d568-63f6bca2ac1f@gmail.com> <1aBKUlb8BGVUUTkRJwEmU3ud1NyeHVCoC7bpOKAuRYlHHJ7hRiDVXYgad-wmjx1K3pykd_ctyY4Lqy9xA7JGLXOm1Eul-imdZ_7TVr5LY8U=@pm.me> <3da84c90-7e12-75ee-a582-025bc68dd098@enterprisedb.com> <5qAu7vrMV3hEodlIC82b0JICWTwEUSRoIDWlIaczNBIEVVfDH2lccxHNIQ726e4nX_Qqjc4lPc5_z9RtV28NMdVv7BNiADF4JB-FDahmlVk=@pm.me> From: Tomas Vondra In-Reply-To: <5qAu7vrMV3hEodlIC82b0JICWTwEUSRoIDWlIaczNBIEVVfDH2lccxHNIQ726e4nX_Qqjc4lPc5_z9RtV28NMdVv7BNiADF4JB-FDahmlVk=@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/14/23 16:18, gkokolatos@pm.me wrote: > ...> Would you mind me trying to come with a patch to address your points? > That'd be great, thanks. Please keep it split into smaller patches - two might work, with one patch for "cosmetic" changes and the other tweaking the API error-handling stuff. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company