Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqAQ7-008OYM-09 for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Oct 2023 10:56:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qqAQ4-0070OD-UW for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Oct 2023 10:56:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqAQ4-0070NR-GA for pgsql-hackers@lists.postgresql.org; Tue, 10 Oct 2023 10:56:57 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqAQ2-001H7F-MW for pgsql-hackers@lists.postgresql.org; Tue, 10 Oct 2023 10:56:56 +0000 Received: from [192.168.1.115] (dsl-hkibng22-54f8db-125.dhcp.inet.fi [84.248.219.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4S4XsJ0sphz49PxG; Tue, 10 Oct 2023 13:56:49 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1696935412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DksOTy5yGpSiVjUvA/iWrX8p9UMG27gn7oxUVcpbaIw=; b=U9Fru7kkEEF9xiyyr2wxUy+UNsJMgS/yIn8nC6kysAo+qaEwwFoENG1RTRQLfoheIPscS2 lvm3x5o/T2FasEhpkNCZQEOPQfnrOt5Uz34X/DpqGeAoHDHJe85ulNEVRTKj1kK/Qw2vwu liTgXxRK3jb16TDzfhRPqKdCSfz4aTtvhnI2+hU6mZHV/UEBSCoae/w2950TygfPVMPUpB tgbOXJEQvPHEJzL9spMcq1I48ELL/TlpnzBl5Jw4jH04zgZxFvLCCxRlL427xRFu0KhCW7 wXSDvwuljpHVEdhRwLfPIXFo+cNNY4hNWflLfs09pY+aCCAbihOiY0BGE1Zdkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1696935412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DksOTy5yGpSiVjUvA/iWrX8p9UMG27gn7oxUVcpbaIw=; b=T4+Rq29qvxaKGR5sDyGEjZPz+ki61fn+PjKuKyESnLpKt3WsSNwO5vZ+wF+oKNEM9kAyeC tpZciDgIV66XnyTF0I6NRQvx3EG8hRh1/hqx/uw0cWMu3YG4dCCkp3lJI7XqpMlfzVjNSc fqECJ8c5Xx+cBmWok0DEADF1K1QQfQyWZeJjheGs5WcDBplNBVK9I3EZIyCnMCU3PJ60CL eVPMZv4R867R7Z2KdBq0VByjTM0dhQIYHQIXjgFEGLzyYnH8jOjVwSlyefxc1CeAgA6qPx q3GHSZDvpQIz5PQo94kjCi+B8kr7tW1lSi8PpXSp79DnaPHVFVJEwgTiCtOaZw== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1696935412; a=rsa-sha256; cv=none; b=fIOWJS202zpAZpJgr5jSYbFfDDnPx/pzfr2LgXi+Erp1keRu/sIRMnAXEJ0ktfDd0R1QlR ZHmJcD5scGSAJAC/tQeNnXVlL1VjqaDBDHSlkXQ79bm9dMUraz2hqsDsRyaMJNQ4Z9Xk80 KW5/t2jVOqEu2yHpUnn6t0xjwhKnhVk3ktg8a7DjaLj0bEX+Q8dlxoaCN5m8LHFhBEiKGH 8gM0JSj6K8D8csLCF8To6wbhROd9t+Zz6NOHVJlV561g1St/Tvx0UPmr46JtpJxs3/Y3pG Eyj9Qsw1HjSQNfZKnXMRaLw+gACKZrZHrRwmN2NqncTd9uvOesadwqe4/iF51w== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi Message-ID: Date: Tue, 10 Oct 2023 13:56:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Comparing two double values method Content-Language: en-US To: Bowen Shi , Postgres hackers References: From: Heikki Linnakangas In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 10/10/2023 13:31, Bowen Shi wrote: > Dears, > > I noticed that in the `check_GUC_init` function, there is a direct > comparison using the != operator for two double values, which seems > problematic. > > I wrote this patch to fix this. No, the compile-time initial values should match exactly. -- Heikki Linnakangas Neon (https://neon.tech)