Message-ID: <d8df5339cab25b5720667beaaed8a8bb8e11578c.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Corey Huinker <corey.huinker@gmail.com>, Nathan Bossart
	 <nathandbossart@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, jian he <jian.universality@gmail.com>,
  Matthias van de Meent <boekewurm+postgres@gmail.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>,  Stephen Frost
 <sfrost@snowman.net>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Peter
 Smith <smithpb2250@gmail.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>,  alvherre@alvh.no-ip.org
Date: Tue, 07 Jan 2025 12:14:15 -0800
In-Reply-To: <CADkLM=c6NHdXU+d+m1yASZ4NT_qye1LCnaU2Vgf8YJ80jJT-Qg@mail.gmail.com>
References: 
	<CADkLM=cxNaU3O40Y5zGARJBWm-uAvb2hvgZxd=tOu-zTsrHpkQ@mail.gmail.com>
	 <5d3a24216d15ce8a50d0fc085a13a410202014ca.camel@j-davis.com>
	 <CADkLM=fcAneLoFrd41zdxm_1mMZz+wTp5gLJ=Av5JtBi5cBnDQ@mail.gmail.com>
	 <c2bc08dfec336c03f7a7165d1347e2b52cf98b17.camel@j-davis.com>
	 <CADkLM=fyJ-Y-DNk1aW09btZYdXDXS79xT8oFPTQ6sspWHaqdog@mail.gmail.com>
	 <3bd40d2c686608196b8e04c2aaac9c57c447aae6.camel@j-davis.com>
	 <CADkLM=cWc+Zbjnpew9sg346DdRQJj8OSvZjg4fwvpLH10EViJQ@mail.gmail.com>
	 <Z22mcdRo_jTcA7nb@momjian.us>
	 <39770e3aebfdf543fa2215fb300621a54b1b2634.camel@j-davis.com>
	 <Z3MGT8TcCOw4U3H0@momjian.us> <Z3xKtmHxPpHNyqfH@nathan>
	 <CADkLM=c6NHdXU+d+m1yASZ4NT_qye1LCnaU2Vgf8YJ80jJT-Qg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/d8df5339cab25b5720667beaaed8a8bb8e11578c.camel%40j-davis.com>
Precedence: bulk

On Tue, 2025-01-07 at 01:18 -0500, Corey Huinker wrote:
> Attached is the latest (and probably last) unified patchset before
> parts get spun off into their own threads.

In this thread I'm only looking at 0001. Please start a new thread for
vacuumdb and extended stats changes.

> 0001 - This is the unified changes to pg_dump, pg_restore,
> pg_dumpall, and pg_upgrade.
>=20
> It incorporates most of what Jeff changed when he unified v36j, with
> typo fixes spotted by Bruce.=C2=A0There was interest in splitting
> STATISTICS DATA into RELATION STATISTICS DATA and ATTRIBUTE
> STATISTICS DATA.

I think we should just stick with "STATISTICS DATA".

> There was also interest in changing the prefix for STATISTICS DATA.
> However, the only special case for prefixes=C2=A0currently relies on an
> isData flag. Since there is no isStatistics flag, we would either
> have to create one, or do strcmps on te->description looking for
> "STATISTICS DATA". It's do-able, but I'm not sure it's worth it.

I do like the idea of a "Statistics for ..." prefix, and I think it's
doable.

The caller needs some knowledge about that anyway, to correctly output
the statistics dump when the schema is not requested. Tests should
cover those cases, too.

Regards,
	Jeff Davis