Subject: Re: Re: SQL/JSON: functions
To: Nikita Glukhov <n.gluhov@postgrespro.ru>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>,
 Dmitry Dolgov <9erthalion6@gmail.com>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 Oleg Bartunov <obartunov@postgrespro.ru>,
 Alexander Korotkov <a.korotkov@postgrespro.ru>,
 Michael Paquier <michael@paquier.xyz>, Simon Riggs <simon@2ndquadrant.com>,
 Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
References: <20190925205515.GA26083@alvherre.pgsql>
 <aaa4153a-f7a2-2b20-7396-d6a4d9b45f19@postgrespro.ru>
 <fb37f08c-e018-4588-3273-628e059c6c4a@gmail.com>
 <f7b4f21b-ea09-a80d-d7b7-f90f16147b2d@postgrespro.ru>
From: Andrew Alsup <bluesbreaker@gmail.com>
Message-ID: <d8f9305c-645a-e303-f7ee-02179d9cba6e@gmail.com>
Date: Mon, 21 Oct 2019 20:50:02 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <f7b4f21b-ea09-a80d-d7b7-f90f16147b2d@postgrespro.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 10/21/19 12:44 PM, Nikita Glukhov wrote:
>
> v39 patch is based on 5ee96b3e2221d154ffcb719bd2dee1179c53f821
>
> Use the following git command to apply patches:
>
> git am ~/Downloads/0001-Jsonpath-support-for-json-v39.patch
>

Thank you. The patch applied fine, with no errors.

Is this the type of testing that would be helpful? I plan to construct a 
number of separate queries to test more nuanced edge cases. This test 
simply compares the output of 4 separate sub-queries that should provide 
the same results.

SELECT
   CASE WHEN jop = jp_expr AND jop = jval AND jop = jval_path
     THEN 'pass'
     ELSE 'fail'
   END
FROM
   (
     -- jsonb operator
     SELECT count(*)
     FROM testjsonb
     WHERE j->>'abstract' LIKE 'A%'
   ) as jop,
   (
     -- jsonpath expression
     SELECT count(*)
     FROM testjsonb
     WHERE j @? '$.abstract ? (@ starts with "A")'
   ) as jp_expr,
   (
     -- json_value()
     SELECT count(*)
     FROM testjsonb
     WHERE JSON_VAlUE(j, 'lax $.abstract') LIKE 'A%'
   ) as jval,
   (
     -- json_value(jsonpath)
     SELECT count(*)
     FROM testjsonb
     WHERE JSON_VALUE(j, 'lax $.abstract ? (@ starts with "A")') IS NOT NULL
   ) as jval_path;


If I'm completely off base for how testing is normally conducted, please 
let me know.

Thanks,
Andrew Alsup