Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyKz8-0001wc-30 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 17:23:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyKz5-0001Yc-Db for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 17:23:39 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyKz5-0001YT-1Z for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 17:23:39 +0000 Received: from ping.uio.no ([2001:700:100:570::196]) by makus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyKz1-0003s3-TC for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 17:23:37 +0000 Received: from [2001:700:100:570::211] (helo=dalvik.ping.uio.no ident=Debian-exim) by ping.uio.no with esmtp (Exim 4.72 #1 (Debian)) id 1eyKys-0003Q6-PA; Tue, 20 Mar 2018 18:23:28 +0100 Received: from ilmari by dalvik.ping.uio.no with local (Exim 4.84_2) (envelope-from ) id 1eyKys-0005Vr-Hk; Tue, 20 Mar 2018 18:23:26 +0100 From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) To: Tom Lane Cc: Craig Ringer , PostgreSQL Hackers Subject: Re: configure's checks for --enable-tap-tests are insufficient References: <516.1521475003@sss.pgh.pa.us> <8906.1521513602@sss.pgh.pa.us> <9696.1521554152@sss.pgh.pa.us> <12134.1521556826@sss.pgh.pa.us> <30398.1521564644@sss.pgh.pa.us> Mail-Copies-To: nobody Date: Tue, 20 Mar 2018 17:23:26 +0000 In-Reply-To: <30398.1521564644@sss.pgh.pa.us> (Tom Lane's message of "Tue, 20 Mar 2018 12:50:44 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Exiscan-Spam-Score: -3.7 (---) X-Exiscan-Spam-Report: SpamAssassin 3.3.1 (2010-03-16) on pike.ping.uio.no Score Rule * -5.0 PING_UIO_MAIL_IS_INTERNAL Message has never been outside * 129.240.0.0/16 or 193.157.115.0/24 * 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Tom Lane writes: > ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> Tom Lane writes: >>> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >>>> I think the other way would be better simpler: we require a complete >>>> Perl core installation. > >>> And you propose to test for that in configure how? > >> Good point, I'd overlooked that aspect. In that case we can't rely on >> what Debian or others happen to include in their minimal packages, we >> have to explicitly check for _every_ module we use anywhere in the test >> suite, core or not (except perhaps pragmas like 'strict' and 'warnings'). > > That seems like expensive overkill to me, especially since it seems > unlikely that we'd keep the list up-to-date over time. The patches uptread add about 0.2s to a 6.9s configure run here, I don't consider that very expensive. We don't add new modules very often, so I don't think it's much of a maintenance overhead either. > I just want to test for modules that we know are likely to be omitted > on popular platforms. I've proposed testing two that would improve > the user experience on Red Hat; what's the equivalent minimum set for > Debian? On Debian (I've checked the previous and current stable releases, as well as unstable) the only package required by the TAP tests not in perl-base is Time::HiRes. Of the modules required by PL/Perl, Opcode is not in perl-base either. BTW, should include the version in the Test::More check, since we only requie Perl 5.8, but that only shipped Test::More 0.47, while we require 0.97. - ilmari -- "A disappointingly low fraction of the human race is, at any given time, on fire." - Stig Sandbeck Mathisen