Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hEu5p-0002lN-4K
	for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Apr 2019 11:11:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hEu5l-0005Vg-CR
	for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Apr 2019 11:11:33 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <ilmari@ilmari.org>)
	id 1hEu5k-0005PL-Pe
	for pgsql-hackers@lists.postgresql.org; Fri, 12 Apr 2019 11:11:32 +0000
Received: from ping.uio.no ([2001:700:100:570::196])
	by makus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <ilmari@ilmari.org>)
	id 1hEu5d-0005bc-Cw
	for pgsql-hackers@lists.postgresql.org; Fri, 12 Apr 2019 11:11:31 +0000
Received: from [2001:700:100:570::211] (helo=dalvik.ping.uio.no
 ident=Debian-exim)
	by ping.uio.no with esmtp (Exim 4.72 #1 (Debian))
	id 1hEu5R-0006FJ-Bo; Fri, 12 Apr 2019 13:11:15 +0200
Received: from ilmari by dalvik.ping.uio.no with local (Exim 4.84_2)
	(envelope-from <ilmari@ilmari.org>)
	id 1hEu5R-00058p-6O; Fri, 12 Apr 2019 13:11:13 +0200
From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
  Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
  Sergei Kornilov <sk@zsrv.org>,
  "pgsql-hackers\@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX CONCURRENTLY 2.0
References: <20190411132704.GC30766@paquier.xyz>
	<20190411134947.GA22043@alvherre.pgsql>
	<20190412031046.GD2144@paquier.xyz>
Mail-Copies-To: nobody
Date: Fri, 12 Apr 2019 12:11:12 +0100
In-Reply-To: <20190412031046.GD2144@paquier.xyz> (Michael Paquier's message of
	"Fri, 12 Apr 2019 12:10:46 +0900")
Message-ID: <d8jbm1b32cv.fsf@dalvik.ping.uio.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Exiscan-Spam-Score: -3.7 (---)
X-Exiscan-Spam-Report: SpamAssassin 3.3.1 (2010-03-16) on pike.ping.uio.no
 Score  Rule
 * -5.0 PING_UIO_MAIL_IS_INTERNAL Message has never been outside
 *      129.240.0.0/16 or 193.157.115.0/24
 *  1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:

> So...  I am coming up with the patch attached.  I have introduced some
> tests using a trick with CIC to have an invalid index to work on.

I don't have any comments on the code (but the test looks sensible, it's
the same trick I used to discover the issue in the first place).

However, the doc patch lost the trailing paren:

>      The recommended recovery
>      method in such cases is to drop the index and try again to perform
> -    <command>CREATE INDEX CONCURRENTLY</command>.  (Another possibility is to rebuild
> -    the index with <command>REINDEX</command>.  However, since <command>REINDEX</command>
> -    does not support concurrent builds, this option is unlikely to seem
> -    attractive.)
> +    <command>CREATE INDEX CONCURRENTLY</command>.  (Another possibility is
> +    to rebuild the index with <command>REINDEX INDEX CONCURRENTLY</command>.
>     </para>


- ilmari
-- 
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least.               - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article.                      - Calle Dybedahl