From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: Marko Tiikkaja <marko@joh.to>
Cc: pgsql-hackers@postgresql.org,  Tom Lane <tgl@sss.pgh.pa.us>,
  Andrew Dunstan <andrew@dunslane.net>,  Matthias Kurz <m.kurz@irregular.at>,
  Jim Nasby <Jim.Nasby@BlueTreble.com>,
  "David G. Johnston" <david.g.johnston@gmail.com>
Subject: Re: [PATCH] Alter or rename enum value
References: 
 <CAO=2mx6uvgPaPDf-rHqG8=1MZnGyVDMQeh8zS4euRyyg4D35OQ@mail.gmail.com>
	<56E049CC.8010201@dunslane.net> <25605.1457539654@sss.pgh.pa.us>
	<56E05635.70908@dunslane.net> <28167.1457543612@sss.pgh.pa.us>
	<CAO=2mx4rQHRvifT2yUQ1rz90A=9CVz4_Z0Sx1wTgwgQRzAimpQ@mail.gmail.com>
	<CAO=2mx6rK_h4BC7y+3Nu-8fuZJXdFjd9FE_MZnzkH+vnMp0C-Q@mail.gmail.com>
	<d8ja8ln7nl0.fsf@dalvik.ping.uio.no>
	<d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no> <56F81BBF.7010905@joh.to>
Mail-Copies-To: nobody
Date: Sun, 27 Mar 2016 18:58:12 +0100
In-Reply-To: <56F81BBF.7010905@joh.to> (Marko Tiikkaja's message of "Sun, 27
	Mar 2016 19:43:27 +0200")
Message-ID: <d8jfuvb4xcb.fsf@dalvik.ping.uio.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Marko Tiikkaja <marko@joh.to> writes:

> On 2016-03-27 19:30, Dagfinn Ilmari Mannsåker wrote:
>> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>>
>>> I was bored and thought "how hard could it be?", and a few hours'
>>> hacking later, I have something that seems to work.  It doesn't do IF
>>> NOT EXISTS yet, and the error messaging could do with some improvement,
>>> and there are no docs.  The patch is attached, as well as at
>>> https://github.com/ilmari/postgres/commit/enum-alter-value
>>
>> Here's v3 of the patch of the patch, which I consider ready for proper
>> review.
>
> A couple of trivial comments below.

Thanks, all fixed locally and will be in the next version of the patch.

-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers