Content-Type: multipart/mixed; boundary="------------HTcqOdE3J7J4kFhY0XcDbU9s"
Message-ID: <d95dc63f-e805-44bc-8429-9be423293620@postgrespro.ru>
Date: Tue, 30 Apr 2024 03:10:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Lakhin <exclusion@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <c73a1746-0cd0-6bdd-6b23-3ae0b7c0c582@postgrespro.ru>
 <CAMbWs49c_7dT_oiP729b-JPRiDtTuDca3exN_cOZZwjGG-0bMA@mail.gmail.com>
 <b907ce77-c054-4009-a871-4d55cb3f73f9@postgrespro.ru>
 <fdaa003e-919c-cbc9-4f0c-e4546e96bd65@gmail.com>
 <edfbd846-dcc1-42d1-ac26-715691b687d3@postgrespro.ru>
 <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <CAPpHfdv1ZkY9cPOqsLvDY9AA-fCYKHM4P07+-Mu+xq5o=daS6w@mail.gmail.com>
 <CA+TgmoYcjL+w2BQzku5iNXKR5fyxJMSP3avQta8xngioTX7D7A@mail.gmail.com>
 <e711faa8-826d-434d-b197-ab51da518fe7@postgrespro.ru>
 <f79fa76f-de07-b930-0bc7-359d6cbab159@gmail.com>
 <b156efc2-5e6d-4eae-8e60-2d483987b42c@postgrespro.ru>
 <CAPpHfdv-uR663BO6G2kRuLEQjob+UBHuD3iyXF+qGHXQFRN0-Q@mail.gmail.com>
 <56e0000c-6b39-44ce-90b4-d3c3062e408c@postgrespro.ru>
 <CAPpHfdvShLh5txtQdh6=ZMCnzGZHv8W+RHAe8pY94rfzghWTAg@mail.gmail.com>
 <5dee3937-8e9f-cca4-11fb-737709a92b37@gmail.com>
 <f8b5cbf5-965e-4e5b-b506-33bbf41b0d50@postgrespro.ru>
 <c45f4c95-0cf7-d0f7-189a-d2d87faec229@gmail.com>
Content-Language: en-US
From: Dmitry Koval <d.koval@postgrespro.ru>
In-Reply-To: <c45f4c95-0cf7-d0f7-189a-d2d87faec229@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/d95dc63f-e805-44bc-8429-9be423293620%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------HTcqOdE3J7J4kFhY0XcDbU9s
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi!

1.
29.04.2024 21:00, Alexander Lakhin wrote:
> I still wonder, why that constraint (now with a less questionable name) is
> created during MERGE?

The SPLIT/MERGE PARTITION(S) commands for creating partitions reuse the 
existing code of CREATE TABLE .. LIKE ... command. A new partition was 
created with the name "merge-16385-26BCB0-tmp" (since there was an old 
partition with the same name). The constraint 
"merge-16385-26BCB0-tmp_i_not_null" was created too together with the 
partition. Subsequently, the table was renamed, but the constraint was not.
Now a new partition is immediately created with the correct name (the 
old partition is renamed).

2.
Just in case, I am attaching a small fix v9_fix.diff for situation [1].

[1] 
https://www.postgresql.org/message-id/0520c72e-8d97-245e-53f9-173beca2ab2e%40gmail.com

-- 
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com
--------------HTcqOdE3J7J4kFhY0XcDbU9s
Content-Type: text/plain; charset=UTF-8; name="v9_fix.diff"
Content-Disposition: attachment; filename="v9_fix.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV91dGlsY21kLmMgYi9zcmMv
YmFja2VuZC9wYXJzZXIvcGFyc2VfdXRpbGNtZC5jCmluZGV4IGZlZjA4NGY1ZDUuLmU5MThh
NjIzYzUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV91dGlsY21kLmMK
KysrIGIvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3V0aWxjbWQuYwpAQCAtMzQ0Niw2ICsz
NDQ2LDExIEBAIGNoZWNrUGFydGl0aW9uKFJlbGF0aW9uIHJlbCwgT2lkIHBhcnRSZWxPaWQp
CiAJCQkJCQlSZWxhdGlvbkdldFJlbGF0aW9uTmFtZShwYXJ0UmVsKSwKIAkJCQkJCVJlbGF0
aW9uR2V0UmVsYXRpb25OYW1lKHJlbCkpKSk7CiAKKwkvKiBQZXJtaXNzaW9ucyBjaGVja3Mg
Ki8KKwlpZiAoIW9iamVjdF9vd25lcmNoZWNrKFJlbGF0aW9uUmVsYXRpb25JZCwgUmVsYXRp
b25HZXRSZWxpZChwYXJ0UmVsKSwgR2V0VXNlcklkKCkpKQorCQlhY2xjaGVja19lcnJvcihB
Q0xDSEVDS19OT1RfT1dORVIsIGdldF9yZWxraW5kX29ianR5cGUocGFydFJlbC0+cmRfcmVs
LT5yZWxraW5kKSwKKwkJCQkJICAgUmVsYXRpb25HZXRSZWxhdGlvbk5hbWUocGFydFJlbCkp
OworCiAJcmVsYXRpb25fY2xvc2UocGFydFJlbCwgQWNjZXNzU2hhcmVMb2NrKTsKIH0KIAo=


--------------HTcqOdE3J7J4kFhY0XcDbU9s--