Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5dz2-0006ab-Cu for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 00:51:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m5dz1-0001Mz-4I for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jul 2021 00:51:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5dz0-0001Mr-SY for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 00:51:38 +0000 Received: from mxout3.routing.net ([2a03:2900:1:a::8]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5dyy-0005j2-08 for pgsql-hackers@lists.postgresql.org; Tue, 20 Jul 2021 00:51:37 +0000 Received: from mxbox1.masterlogin.de (unknown [192.168.10.88]) by mxout3.routing.net (Postfix) with ESMTP id 67615604E1; Tue, 20 Jul 2021 00:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1626742294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=06Zr7P404oRC8ibwMUttytmQeJ+D3baUS6ll1qcEBPo=; b=gCK6I7H5ErMOH5ZhXi+mDGHznOkze3CG/VhIUe0Eo1zR+T9aNcP50CyFWOvUN9S9PTFBJU jIpAbm+V7CEMnBkEilW1QOwiAylA+M16rmNXa4wTTHCPWnAnqsorMZFzwLAjwIoazIK6bx 2CV2c2QpGS05zCPFZ100T3weOJhiF+M= Received: from remote.index.de (p578a9a34.dip0.t-ipconnect.de [87.138.154.52]) by mxbox1.masterlogin.de (Postfix) with ESMTPSA id CFC61403D5; Tue, 20 Jul 2021 00:51:33 +0000 (UTC) Received: from acedia.index-gruppe.local (192.168.3.121) by acedia.index-gruppe.local (192.168.3.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 20 Jul 2021 02:51:33 +0200 Received: from acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947]) by acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947%13]) with mapi id 15.01.2176.014; Tue, 20 Jul 2021 02:51:32 +0200 From: Arne Roland To: Alvaro Herrera CC: vignesh C , Zhihong Yu , Pg Hackers Subject: Re: Rename of triggers for partitioned tables Thread-Topic: Rename of triggers for partitioned tables Thread-Index: AQHWxEk1+rora/wutkWbcRQhC03q0KnbGQ2sgAAECBOATmSTgIBhAeKAgBDG6bOAACCNT4AAKOcAgAAj1kP///tHgIAEsSJngAHhzjCAhX9QJP//43kAgAAjD3T///1iAABXUKhwA1bKhQAABHSL9QDdrxEAAARjdxIAANC5/g== Date: Tue, 20 Jul 2021 00:51:32 +0000 Message-ID: References: <6e6491608f694ca488a5d7c404c4b98d@index.de>,<202107200003.nve6a53eixra@alvherre.pgsql>,<004683a28e714bf3beb9a413a2ffbcb9@index.de> In-Reply-To: <004683a28e714bf3beb9a413a2ffbcb9@index.de> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.1.33] Content-Type: multipart/alternative; boundary="_000_d969d76ba62749699973a12499f944ebindexde_" MIME-Version: 1.0 X-Mail-ID: 7f454731-99ee-432e-a0cb-10c1bdaea022 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_d969d76ba62749699973a12499f944ebindexde_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > We are referring the trigger via it's name after all. If a child is named= differently we break with that assumption. I think informing the user abou= t that, is very valuable. To elaborate on that: While we to similar things for things like set schema, here it has a functi= onal relevance. ALTER TRIGGER a5 ON table_name RENAME TO a9; suggests that the trigger is now fired later from now on. Which obviously m= ight not be the case, if one of the child triggers have had a different nam= e. I like your naming suggestions. I'm looking forward to test this patch when= it applies at my end! Regards Arne --_000_d969d76ba62749699973a12499f944ebindexde_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

> = We are referring the trigger via it's name = after all. If a child is named differently we break with that assumption. I think informing the user about that, is very= valuable.


To elaborate on that:

While we to similar things for things like set schema, here it has a fun= ctional relevance.


ALTER TRIGGER a5 ON table_name RENAME TO a9;


suggests that the trigger is now fired later from now on. Which obvi= ously might not be the case, if one of the child triggers have had a differ= ent name.




I like your naming suggestions. I'm looking forward to test this patch w= hen it applies at my end!


Regards
Arne


--_000_d969d76ba62749699973a12499f944ebindexde_--