Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rOKrz-003Kci-K6 for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Jan 2024 16:59:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rOKry-003eBn-II for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Jan 2024 16:58:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rOKry-003eBf-3z for pgsql-hackers@lists.postgresql.org; Fri, 12 Jan 2024 16:58:58 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rOKrv-001Deu-Bc for pgsql-hackers@postgresql.org; Fri, 12 Jan 2024 16:58:57 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-28be8ebcdc1so4739874a91.0 for ; Fri, 12 Jan 2024 08:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1705078733; x=1705683533; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Jl7o+qz/2Ri4ODJ2OMUd92RPt/I0O3DaV2OmrxWyWT4=; b=jpinDD57onn+z9YGxesTps+wbtO1tcqikjIRZUFZTSYo4NNj1WYLX1vH9lGztyYSpV JIC2Bqta6rci5tuGuM6VJ+McMAFkeHBM0w/fI2S7X6rgwIbAkqvb/eoQayF1eDOcFweA pY5jZA4dWDgExbA9xoIyLdCD4EX/B1aZIQu3t1M5ETYV8KvI3SDXGaUDcptKprcqLJ0/ Eqlrk+ep+fmF1BufpfDOka7UM0+/rDwm1bWwuFOByWJMDtwsIMmp9AKT09KOriLeGg68 iThbY63VLVBQgAAj9AFKsEwGVxcaBRb5EQDrgtdzHbcrhypj6i7Pp2MSRDfzWDR/PMBe T68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705078733; x=1705683533; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Jl7o+qz/2Ri4ODJ2OMUd92RPt/I0O3DaV2OmrxWyWT4=; b=DQYRUTp8DK13vmwj1Wp4VEJlNqc89cEqf0uAEsGWfrpN1eZSrLwqYC+HqwJLD91hqh ffs0ez8+CigKgTFpwXA7JqqDHaYMVjZxb3z49bBd1rhGLwtHNsREA7wrvaBKzcREHDpq CxOcqexpRpCDjMLEMCtXvmx7bwtIQApJA01AdrH3O0kFwUlCMRWnStJPcRN1F0cNyDDM AcOX5/0Y0Is1t5F60J1yz2Lw58jjS3/3C9UE8iyTrrTJBvC4Uh2E+IVos3ASrJO5vhSf hnxA7GBvRw5Kg0meeVAaER99ijMUxk9WcGeb/iJ5yQNgrw9RqzQ/stud02l0Mmdi8Tqy ERqg== X-Gm-Message-State: AOJu0YxoQAQOkwoq7UTKpR7EO3X3pPoZNFAjptWEyzynKZ+nlIARYhJP y69o2SAKNoWErucDJX6KCi6qbROANPIo X-Google-Smtp-Source: AGHT+IEkl0sHIrbnzFlG6sY5mavmSu+/RBnZVFlc89x7QyiVDbCkraRHitT2iIyQ3MIqph0n37PGLw== X-Received: by 2002:a17:90b:1d81:b0:28c:ef2b:d58 with SMTP id pf1-20020a17090b1d8100b0028cef2b0d58mr1415836pjb.69.1705078732878; Fri, 12 Jan 2024 08:58:52 -0800 (PST) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id sc4-20020a17090b510400b0028b89520c7asm4381973pjb.9.2024.01.12.08.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 08:58:52 -0800 (PST) Message-ID: Subject: Re: Built-in CTYPE provider From: Jeff Davis To: Daniel Verite Cc: Robert Haas , Jeremy Schneider , pgsql-hackers@postgresql.org Date: Fri, 12 Jan 2024 08:58:51 -0800 In-Reply-To: <12e4f6a78403b33c303c20e44976f891d879be09.camel@j-davis.com> References: <6f3e94c0-f174-4380-9b69-072f8a838881@manitou-mail.org> <12e4f6a78403b33c303c20e44976f891d879be09.camel@j-davis.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, 2024-01-11 at 18:02 -0800, Jeff Davis wrote: > Jeremy also raised a problem with old versions of psql connecting to > a > new server: the \l and \dO won't work. Not sure exactly what to do > there, but I could work around it by adding a new field rather than > renaming (though that's not ideal). I did a bit of research for a precedent, and the closest I could find is that \dp was broken between 14 and 15 by commit 07eee5a0dc. That is some precedent, but it's more narrow. I think that might justify breaking \dO in older clients, but \l is used frequently. It seems safer to just introduce new columns "datbuiltinlocale" and "collbuiltinlocale". They'll be nullable anyway. If we want to clean this up we can do so as a separate commit. There are other parts of the catalog representation related to collation that we might want to clean up as well. Regards, Jeff Davis