Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpa2p-0004rR-4B for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Sep 2017 13:07:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dpa2o-0002Ak-IU for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Sep 2017 13:07:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dpa1H-0007u3-Ku for pgsql-hackers@postgresql.org; Wed, 06 Sep 2017 13:05:27 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dpa1E-0008NV-4d for pgsql-hackers@postgresql.org; Wed, 06 Sep 2017 13:05:27 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CBCB021933; Wed, 6 Sep 2017 09:05:22 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Wed, 06 Sep 2017 09:05:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=+xC4OPJBVJIHFCtZL8WMsROOhRb7cK2aM5TwLtU/E3A=; b=ByhThNRu 1VaAX8LtiIOmJFeqVcmMZVSCv84Jb0glFVJKnEZ69SHFt7umjig1LFTS60F0kUf4 pouRHC7WVx9IjjunNtf/AU25/6L9Hln6F8j3B/E4oRwQ+32vxf+bKFHO9/T7a8vJ 2UGNCPCoNXszwvMWnPNSMWva3sClk1sJ0kr6slw5byZ7OGmE0Wh1x2Sl4ESwf+0J KNrPtO2UJNSuVNoJpZIkPIsbHl3mTEOQtuPHvhYUkA/Q9ZVzDgHQ5H+dpQHbSsQi x2tdcnVA+XnwSlGZXO82EmWQZkX1JG8iICfMrq9nlWz3FKj96D4ACN2+/EIgPQGc Tr+V2meMxnaFow== X-ME-Sender: X-Sasl-enc: OXIWdU9LXG+47ldNxkm2x+evz8IqQ687EsyeRVdZG6s8 1504703122 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 7CABF2489D; Wed, 6 Sep 2017 09:05:22 -0400 (EDT) Subject: Re: Rewriting the test of pg_upgrade as a TAP test To: Michael Paquier References: <20170403151237.GK9812@tamriel.snowman.net> <20170404123011.GX9812@tamriel.snowman.net> <20170405132426.GW9812@tamriel.snowman.net> Cc: PostgreSQL mailing lists From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Wed, 6 Sep 2017 09:05:21 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 4/14/17 02:00, Michael Paquier wrote: > Attached is an updated patch to use --no-sync with pg_dumpall calls. Please send a rebased patch. I propose splitting the single Perl script into three separate test files: one for basic command-line option handling and so on (I would like to expand that later), one for the main upgrade test, and one for the funny database names tests. In the testing file, you removed the paragraph that explains how to do cross-version upgrade testing. It's unfortunate that we would lose that functionality. What can we do about that? We also need to have a plan for handling the build farm. Maybe keep the vcregress.pl upgradecheck target as a thin wrapper for the time being? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers