Feedback-ID: ie0a040ee:Fastmail
Message-ID: <da997cd8-4e63-4a4b-ab09-8b51b4d19b2a@eisentraut.org>
Date: Mon, 19 Aug 2024 11:20:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
To: Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>
Cc: Sofia Kopikova <s.kopikova@postgrespro.ru>, pgsql-hackers@postgresql.org
References: <e0b17014-5319-4dd6-91cd-93d9c8fc9539@postgrespro.ru>
 <CA+TgmoZ+NDotjPyVWrBJNZvv2XLYnHq3uVkpQRGe5WdaoHxt8A@mail.gmail.com>
 <ZsLjrPgdNkyXr7pW@paquier.xyz>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ZsLjrPgdNkyXr7pW@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/da997cd8-4e63-4a4b-ab09-8b51b4d19b2a%40eisentraut.org>
Precedence: bulk

On 19.08.24 08:18, Michael Paquier wrote:
> On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
>> This seems correct to me.
> 
> It is not the first time that this happens in recent history.  Would
> it be worth automating that?  I would guess a TAP test that takes a
> copy of the headers, applies the changes while filtering the few
> exceptions, then compares it to the origin in the tree?

Probably worth thinking about, but it would at least require some kind 
of exclude list, because there are exceptions like src/include/common/ 
/logging.h.