Message-ID: <daa2d17d5544e0f75ea05b1024c9feec74b46c12.camel@j-davis.com>
Subject: Re: broken master regress tests
From: Jeff Davis <pgsql@j-davis.com>
To: Alexander Lakhin <exclusion@gmail.com>, Noah Misch <noah@leadboat.com>,
	Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Thomas Munro
 <thomas.munro@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Matthias
 van de Meent <boekewurm+postgres@gmail.com>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Date: Thu, 28 Dec 2023 09:36:42 -0800
In-Reply-To: <ae73f6f5-8221-c112-4640-5cda812a69de@gmail.com>
References: 
	<CA+hUKG+VkcevnqLmbZSD4C5hJ3=TQWgMP-th8LqsbNt0TqZfqw@mail.gmail.com>
	 <20230829155424.bem25upvaefkqqyy@alvherre.pgsql>
	 <20230912022358.d5ln25sglrntwaia@awork3.anarazel.de>
	 <0d47e5ecc037b3908149aad5f2a987793cf938bd.camel@j-davis.com>
	 <20231011005434.34oc4v4pv6ajqkss@awork3.anarazel.de>
	 <20231213025619.70.nmisch@google.com>
	 <97c9d15247c5919b444b2e217b4c886271be0ea5.camel@j-davis.com>
	 <c6571aac4c6da3e2f013fe74fcc95d6e052bf04c.camel@j-davis.com>
	 <ae73f6f5-8221-c112-4640-5cda812a69de@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/daa2d17d5544e0f75ea05b1024c9feec74b46c12.camel%40j-davis.com>
Precedence: bulk

On Thu, 2023-12-28 at 18:00 +0300, Alexander Lakhin wrote:
> AFAICS, before that commit SELECT getdatabaseencoding() in the test
> returned SQL_ASCII, hence the test was essentially skipped, but now
> it
> returns WIN1252, so problematic CREATE COLLATION(locale =3D 'en_US',
> ...)
> is reached.

We do want that test to run though, right?

I suspect that test line never worked reliably. The skip_test check at
the top guarantees that the collation named "en_US" exists, but that
doesn't mean that the OS understands the locale 'en_US'.

Perhaps we can change that line to use a similar trick as what's used
elsewhere in the file:

  do $$
  BEGIN
    EXECUTE 'CREATE COLLATION ctest_det (locale =3D ' ||
            quote_literal((SELECT collcollate FROM pg_collation WHERE
collname =3D ''en_US'')) || ', deterministic =3D true);';
  END
  $$;

The above may need some adjustment, but perhaps you can try it out?
Another option might be to use \gset to assign it to a variable, which
might be more readable, but I think it's better to just follow what the
rest of the file is doing.

Regards,
	Jeff Davis