MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 17 Jan 2018 18:46:13 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: vitus@wagner.pp.ru, Andres Freund <andres@anarazel.de>,
 pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: master make check fails on Solaris 10
Organization: Postgres Professional
In-Reply-To: <16720.1516201657@sss.pgh.pa.us>
References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru>
 <20180111173938.jimybeayp2u5mmup@alap3.anarazel.de>
 <31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru>
 <fc3c1b52d2d4121cccfc13635005bbd0@postgrespro.ru>
 <1232.1515780057@sss.pgh.pa.us>
 <b946893927ccfd87146d8a7c9f3bbe29@postgrespro.ru>
 <15299.1515867055@sss.pgh.pa.us>
 <a5559105243efcf6fb619d86c5702115@postgrespro.ru>
 <18209.1516059711@sss.pgh.pa.us>
 <90ab676392c8f9c84431976147097cf0@postgrespro.ru>
 <16720.1516201657@sss.pgh.pa.us>
Message-ID: <dac03dda4a743d293015b272eb1e6377@postgrespro.ru>
User-Agent: Roundcube Webmail/1.2.4
Precedence: bulk

On 17-01-2018 18:07, Tom Lane wrote:
> Marina Polyakova <m.polyakova@postgrespro.ru> writes:
>> investigating the regression diffs, we found out that the error occurs
>> when we pass int128 as not the first argument to the function (perhaps
>> its value is replaced by the value of some address):
>> ...
>> Based on this, we modified the test program (see attached). Here is 
>> its
>> output on Solaris 10 for different alignments requirements for int128
>> (on my machine where make check-world passes everything is OK)
>> (ALIGNOF_PG_INT128_TYPE is 16 on Solaris 10):
> 
> Excellent.  This fails the same way on gcc 5.2.0 and 5.5.0?

As Victor answered in [1]:
> Unfortunately, we have only one Sparc machine and started our
> investigation by upgrading GCC 5.2.0 to GCC 5.5.0, so it is hard to
> downgrade and test with older GCC.

>> Maybe some pass test from int128test2.c can be used to test __int128?
> 
> Yeah, I can work with this.  What I propose to do is use a somewhat
> stripped-down version of this test as an AC_RUN_IFELSE test normally,
> but if cross-compiling, fall back to just seeing if we can link.

Thanks, I'll try to do this.. And Victor attached a stripped-down 
version of this in [1].

> Thanks for investigating!

Thank you! :)

[1] 
https://www.postgresql.org/message-id/20180117181359.3a6cc06c%40fafnir.local.vm

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company