Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7V9z-005cEf-Px for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Nov 2023 06:32:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r7V9x-00B1jf-E9 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Nov 2023 06:31:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7V9w-00B1ic-W3 for pgsql-hackers@lists.postgresql.org; Mon, 27 Nov 2023 06:31:57 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r7V9u-007YU4-Et for pgsql-hackers@lists.postgresql.org; Mon, 27 Nov 2023 06:31:55 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a0b7f793b8aso191451866b.2 for ; Sun, 26 Nov 2023 22:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20230601.gappssmtp.com; s=20230601; t=1701066712; x=1701671512; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=F+zyMq4F0u64Q2IjR2fGW9MkI86iBdQgeh7Em5QAHOU=; b=YuZ86aMkgJGmBsDJOkDNJ/ZBOXWJ2JroFFB0gnqSkUz7cTqIN2QLzgItJs5S294XRd AmE8Pzl7ombSxkywDknkJVCe54a+gQQWkGLf65z0f45HoGt6l33kXS/952NXoOc9DYs+ 05bCzUmTk/xJIsZFONIA80rp/0X/+v5FKHmfluGNekp8HDgSfjF1euMiK8DSc9l84k8l /jzw9LLUcMD1WK3MBVNnTXYdP9uB4QvnPEDuGhyv7uHlsaNYzVGeDKnIBBcXmlerXFLM WwWFXO8Efh5YeuYOfJ/o6cDkdYvuYWlEKvZiBWwJIAeL+rlTHtYAN4YHciEW5npwhzGR ctAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701066712; x=1701671512; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F+zyMq4F0u64Q2IjR2fGW9MkI86iBdQgeh7Em5QAHOU=; b=hDAvVvhHpDm/+3Smfq8anZKfndFgAgowMv62AB/1plk1XKaaOxERF40jzFFIcAHZcC NgE7ObOqSvni0zJN9UVy7eIGK10+1bmXpSN9RNGKY37CAzReM+j8fc2OwR79Pygr7ve6 d0W36pHn32LPe3KRNAUVsmzq8weExBku5g5mZGmdi1vIB3kXzpt90iagboSeWOpd2Yqe /1QLHyacgRyaXSzYlqEBl5095/G84yQQnyYjv3eAYlp71PnFRR+5epyMYc4QKvXYu7fi /lYkoHl4KYOdThEF2N7953rVByV+qk3sB/fKaTagdWlJELTIowRbL/arTH7bFwUk5ghV foIw== X-Gm-Message-State: AOJu0YwXBj/l18FSUV5f7t/79R/yYYbWNhKQkTULTB1+PrndUFI+D0bj +YIN1ZgjassRnABITQ6MhihRAg== X-Google-Smtp-Source: AGHT+IFUYKgnYude656VeSNFwur5Qcpug4uqYZs4tgJqR3l1TKLPC9nF52y6sajzwMsehfBXiCDxzg== X-Received: by 2002:a17:906:225b:b0:a0e:2616:d91b with SMTP id 27-20020a170906225b00b00a0e2616d91bmr2628697ejr.17.1701066711965; Sun, 26 Nov 2023 22:31:51 -0800 (PST) Received: from localhost.localdomain ([2001:871:260:ce4b:3efa:9f:2675:fc7c]) by smtp.gmail.com with ESMTPSA id s20-20020a1709066c9400b009fd585a2155sm5289991ejr.0.2023.11.26.22.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 22:31:51 -0800 (PST) Message-ID: Subject: Re: GUC names in messages From: Laurenz Albe To: Peter Smith , Michael Paquier Cc: Alvaro Herrera , Nathan Bossart , Peter Eisentraut , Tom Lane , Daniel Gustafsson , PostgreSQL Hackers Date: Mon, 27 Nov 2023 07:31:50 +0100 In-Reply-To: References: <202311240953.6linnh7oxsdn@alvherre.pgsql> Autocrypt: addr=laurenz.albe@cybertec.at; prefer-encrypt=mutual; keydata=mQINBGGDwAQBEADgbWy5cKXQld3N2mF+DFyiNFbi2oBl2T+XgxpPF8wTRw2D/u4bBKXP0SYSE/lA86jIVNWWU0gf1KODIkVvgJm2w4vH2VBV1b7ddVViGl1Iu+9zaRnv9wulhnH42KefepXnoean6UT1EzLM0opF/Ik0j+40TxdRtobkBprkQUyHDXWlHc2ffPs3SipyFEP9AVLf7ejRC46CXWDnsqjOBSMEW8Z4HiK/8RrPZBsKLts8dJxKF4pygOdJb0CWk8k/X1jbcfdxo+zOLjOMvJcSJ2pFdJmQHU+JufB3rePziqQ2S9Ur6sccr9XnTC1GVBWN4Lf5VHq+vf+bFJjVwg+2hrySZnAVfcOrxoqFLErr7ug1zN2nM1kcpgA4VWn4gxlJtYNYYq+9WxX5dtvnNANlG3ZCrRKQzl8lxtzoF6Zo7LUhEqPaHDwn7Rvs+IdbOn41lF5UDTJGqmC4gS/bZydW2Fy3YWm4aSaN9fgFf8D+PVkrlKAZB7gBLz1TyHjbcRf85cYF+GKKrDld5SzMB/V60VX3oP/Eo8ikFpyWaqiz1f9X7MBot3/PjJkY+wDzp3nmb19QEcOBuQiSQ4xds2r0HewbuHTAR68u8jNNMGmpm2j4x+g09Jd/WQDjqlTBZ/jEltH41fYCCPWMfljXTOOXu2eLNGdfi7ETZogtwjM9oTtSPQARAQABtCdMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5hdD6JAk4EEwEIADgWIQR0CqhbZGGABqoaSbdi8bhXA2EdmAUCYYPABAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBi8bhXA2EdmM/6EADK232JCwmBzhlj8h7U9CjG6kx0JHP3uJGv+XfsHtHAlmY/RCwF1BHMEsRlk bT5UrLvJ2jb99bA9QARzhFaxzyn0F/BUKzuIjRGNs/n6d5dNUFA0kOt8sX+TacmC GEyjEBCrVCm4ranBiUyePn9NhHNWnaex7pJyqvMLLdwW9BEMJx0Fqo+DN8ukbXmYRsmhEtd3ue+x/luYmOmJnaGtzInaY5aOJYbW9XqoRIZkZvOCgbi1FfvNmoqWa+3oVxTOgw9RafjJDyW0lTHzKGjbGI5ofMU98l+/hKJFYJqWUF6VpFJY5YIcN/1lf4ZICMwDl+MPIVo/tpq8L10seJL28nLlvw3K+cI+TVW8IW/qL/LyVoDofI3USeOORuYmhpWRhik8JXX6xf3v6GrRilJIPWNFIJbxm1ZblQiQnOw3IOW7T+8nAmPin1HKqM3VrOrJQ2VtShsefNBibNAsr1oFaqcDBkn3yGG8i6CTW+FyO4PZ+/EwNxMVgktxbYdy5AT1/lpXr5tB+phhLIyVfiBvrWs5EThxYMQ/L8Y85c3GMsAy1l/x4h3jqySIYy3SCU9+jc5UVuNnXljbvkEzJ+NLWJ6C1rACFWrMszgPdh5tCrlRY9PpmYll4JbCgb8BtxEIUmR+xr50/ZElEK5iml7Q00KUekCcDt+36PsyGFTXBzNOrkCDQRhg8AEARAAzOZ2tLHlI4rrhG411h6cdCFjBZxuljaFCxFyHn3m6wbGLqwBUWC5k8UrRqjHMz88KcTSaNO7XGAmCqPdWd2SeflPZRnNTbjsVpw7mLdffsBm4JX7kki2Pvk5h0NtYeidXT1PSpc2ri4DutYXuT9uD8RAm1wUDCE5HQNUihT/WH6opt+hskHW21uHao0+y822tG0QQcGMqdQR5Vxdxj89wiEPdqW+HpU/oOZIhrf2E7prduAppxixjHy/o1rcnoznnJvc8D3+YgI9O0LrBMij89dM55pRGbLovTR1oGR3U74sX774+0xmSzeIKwZfiMUz7Atlvfk5SHOsRUFPN2Ux9kaXiiBibQpHFxt7b lDrT4wxdLJ/XCdbPPAyl+lZtOLsaHEEZvYNyTXwZc35dVf3R4/oz20HoG6s7ct8e1 AQygj43XAERzty9SkWgxs8+grp1PrGx6FHVSYRqBM8dS/ZR6yRVwOwJXPyaSSqfIF21DkE4j1y4n+ItSewPGoRp8K/yWCikt6qlkVkO2ASNIiX04fAbtzwVOaNn8ZMRNqyvLc1fED4sr49onE4cAIcBLjcC3KL+w9DUGRQCdziROj5H2Yl/sXGPdMciUHo/Uz2rggc+2th3bQiMhrHWSsBpUkDQp0yWewemstPpPgBL3h2fHKaX8B9oH5Qu/H1IgrOuX8AEQEAAYkCNgQYAQgAIBYhBHQKqFtkYYAGqhpJt2LxuFcDYR2YBQJhg8AEAhsMAAoJEGLxuFcDYR2YuPwQAMkpGtR80pQ1gVsONhdkqj0H2eU66efP/gO3CoyaoIcvrpKYj7C2HipVSmkt1gpByL0X4AMQ/vKuknUz3wd28Ba+G1dCfbVs/Xiusq+SmpUj5rTwmYqdSjWMuCo1R6oS5hdJMdUUJYGMT0QkVlm1KnW8jkmCTl9GzjDxOAsN9O6/6lPzaGFtk9XF+34Bry/N4HKiJkqpC4+UTd0AprPfzJ2jdT64e1F0+W88X8y1bTTgNrHwK4mDiLnlE4SKRuEm54lNhJz//ar86Or5BErzNpM6TL7lk44QS06hwsMrEdKIy8J/SYJPjfzR8tIUnKscclVpOgjKaBqC+0iFiVaRqAgfOlIEiezX6kMh5Q2FIUfqs46qWhhXjRrdKOEoStYAaikdLu5ZXr7vfb0ZaDh+ZwTQtbSMFolyOkecwI81MCdbMfT/1TqIGTOdAj5as9fAakk0jb2pXgUYQ8X1DVTR8ahSDVEaw9VTmWiSvTxvguVJ1Mb7gG4Gmh6aviDTJhfXtH4rPUNXhDLqrTH8JkJjyKROOMakIF68Hjse5vUfUxreBEOtb5r1Coa2Fe7ncJayaSE7ryrDbFqpZ 36UMAx4ulWMyqJajLNGY0DdG8qIsR5nxRhrnK/mrCidZ8F9/D3bWAl4rjtHlsztN59 +AnW5l0HsQcY9ntFL/zEBOaonjdJf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, 2023-11-27 at 13:41 +1100, Peter Smith wrote: > TBH, I suspect something fishy about these mixed-case GUCs. >=20 > In the documentation and in the guc_tables.c they are all described in > MixedCase (e.g. "DateStyle" instead of "datestyle"), so I felt the > messages should use the same case the documentation, which is why I > changed all the ones you are referring to. I agree with that decision; we should use mixed case for these parameters. Otherwise we might get complaints that the following query does not return any results: SELECT * FROM pg_settings WHERE name =3D 'timezone'; Yours, Laurenz Albe