Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jBLAr-00042m-71 for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Mar 2020 16:22:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jBLAp-0001jh-AL for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Mar 2020 16:22:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jBLAo-0001ja-Od for pgsql-hackers@lists.postgresql.org; Mon, 09 Mar 2020 16:22:35 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jBLAm-00035C-4c for pgsql-hackers@postgresql.org; Mon, 09 Mar 2020 16:22:33 +0000 Received: by mail-pj1-x1043.google.com with SMTP id mq3so62666pjb.0 for ; Mon, 09 Mar 2020 09:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=UXDwZPsX50NDQrWFTQyxB+8/vb3CblxHzIDbFAGZgeM=; b=nh9mYi+v9M2garMFSGqyoDvblk4Z+byP0zbHYW56LuWxraZBIuGYAqSaUA+FxOYkpJ zWKBuF2mAx0YYDj8AnWzvGY8Au0nuyVkt2I1quZ2eGNtEA1fJhqacKtBLw4vhlvk+OCJ hrxu4RCAonlY2a108R5EKvcT3P0MJYOFGD7YIn+Hntn85rcqiBmRdJQ2YHbPtI76FV84 yKKPRdQwbzl1ap4iaEoPAhakmL6FE0L3VlkmzV4LzQy8wRj4uHPiTl2GaQ6AGt1SnFtz rReqXp+Oin6xXZ9AEd5a5ict49K40WcCgWYOExPcB4EKXetRor9wADYL2+Tos85F7Abl n1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UXDwZPsX50NDQrWFTQyxB+8/vb3CblxHzIDbFAGZgeM=; b=HagVKAy+Qhxug5erZNwSE6VvjLOT8MO/u/3X8Mtu6VVr1O0p/RXcYS3VI/MqcoYV+8 LECrax8SQtCmHpH9lb6e/EJwOwlAHZSJhB3LOe5Evo5ZdPMFdS1c1kBIUpLgc4jV7XW1 ZX+3bHcmkF6xYznByVq2gIqRub61X9ufhjbbRlKc9dfLOEkfQbRCsQXRMngZfjjp/e68 VydR+aY6YhUss/m4mU7RwId0Dnbh4X6Z9H0W3WYsarb0fquZmXaKx3zSCjokWzsDuFKV mai9kg022pCpOMHDqL32qsLOu/BHD0BxwWNhey0cbuLfYw6F8MGa7XHceOwBBmASBI32 IlfA== X-Gm-Message-State: ANhLgQ3OYb5lwLAiQ1VmPOoHXlw7m68faoYj04zZmacwByOfu9bpfiIs Bo4fzg9hgY9bPPntkrOGznKbUjlrGcGVix097iNoUfm18HcgKgD3vkhw72fWFo2n/zP1P3kFdxE paool4Y9YEEJcSPQp5FbkZXWLyTVxWByY+4PcrQkTnTv1x+vX58hK7xYTJOn8T9OWEEmPQb63pc zYIYZofJe761GCcNACt6FgNnshQ5mGaA== X-Google-Smtp-Source: ADFU+vuYTc4jvLZemfd5i8C/8vCnArjH53fibqgQ9TcoURz36N4v4vGTIUJJCwVb1q70gPxmUPzq3Q== X-Received: by 2002:a17:902:bcca:: with SMTP id o10mr14315247pls.160.1583770950665; Mon, 09 Mar 2020 09:22:30 -0700 (PDT) Received: from localhost.localdomain ([114.143.109.178]) by smtp.gmail.com with ESMTPSA id z3sm45545754pfz.155.2020.03.09.09.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2020 09:22:29 -0700 (PDT) Subject: Re: backup manifests To: Robert Haas Cc: Rajkumar Raghuwanshi , Suraj Kharage , Rushabh Lathia , Tels , David Steele , Andrew Dunstan , PostgreSQL Hackers , Jeevan Chalke , vignesh C References: <8d81bcd9-fa06-a8a2-10e2-8368580e8e4f@enterprisedb.com> <951f68f6-734d-3473-631d-dc84efac41bd@enterprisedb.com> <73e82c3f-5914-8c01-95b1-d03fbf1ad000@enterprisedb.com> <08fb5011-091a-0590-9ca6-01449a4c8779@enterprisedb.com> <3d2b645c-b373-7946-8b33-f1fd879c368d@enterprisedb.com> From: tushar Message-ID: Date: Mon, 9 Mar 2020 21:52:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 3/5/20 10:25 PM, Robert Haas wrote: > Here's an updated patch set responding to many of the comments > received thus far. Thanks Robert. There is a scenario - if user provide port of v11 server at the time of  creating 'base backup'  against pg_basebackup(v13+ your patch applied) with option --manifest-checksums,will lead to  this  below error [centos@tushar-ldap-docker bin]$ ./pg_basebackup -R -p 9045 --manifest-checksums=SHA224 -D dc1 pg_basebackup: error: could not initiate base backup: ERROR: syntax error pg_basebackup: removing data directory "dc1" [centos@tushar-ldap-docker bin]$ Steps to reproduce - PG v11 is running run pg_basebackup against that with option --manifest-checksums -- regards,tushar EnterpriseDB https://www.enterprisedb.com/ The Enterprise PostgreSQL Company