Message-ID: <db541ea000b2371c323c1f5c00ebca2c3a3e28c0.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Greg Sabino Mullane <htamfids@gmail.com>, Ashutosh Bapat
 <ashutosh.bapat.oss@gmail.com>, Corey Huinker <corey.huinker@gmail.com>,
 Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Michael
 Paquier <michael@paquier.xyz>,  Nathan Bossart <nathandbossart@gmail.com>,
 Bruce Momjian <bruce@momjian.us>, Matthias van de Meent
 <boekewurm+postgres@gmail.com>, Magnus Hagander <magnus@hagander.net>,
 Stephen Frost <sfrost@snowman.net>, Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 alvherre@alvh.no-ip.org, jian he <jian.universality@gmail.com>
Date: Tue, 01 Apr 2025 13:24:14 -0700
In-Reply-To: 
 <CA+TgmoaFpHyW1ZwCjNxJmvCR0NRMLYCkA=O50BCKLGnC1UcJNg@mail.gmail.com>
References: 
	<CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
	 <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com>
	 <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
	 <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com>
	 <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
	 <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
	 <1457469.1740419458@sss.pgh.pa.us>
	 <CADkLM=eWSv2z_DVB=psfwHitq7DbFJQaP9A46R27eARC-4OYtQ@mail.gmail.com>
	 <cpdanvzykcb5o64rmapkx6n5gjypoce3y52hff7ocxupgpbxu4@53jmlyvukijo>
	 <CADkLM=dX67xer59tVYMCQZ+pHAT2sCyyrUDzeDCdW_TdxqwOgA@mail.gmail.com>
	 <curtrasm6ylt7es2ukfuals2mh5an72yzxgvyel65mw3ere7qs@nw6m4ffpo4m3>
	 <8d13e4296408c53a93390525d0bcb906cbd13df4.camel@j-davis.com>
	 <CACJufxHG9MBQozbJQ4JRBcRbUO+t+sx4qLZX092rS_9b4SR_EA@mail.gmail.com>
	 <CAExHW5vf9D+8-a5_BEX3y=2y_xY9hiCxV1=C+FnxDvfprWvkng@mail.gmail.com>
	 <768b2a237e892bf1334bdcbb066cdc1bd1368cb2.camel@j-davis.com>
	 <CAKAnmmKCgnqcd3x4Z+5yXsY7urpDS6D_NZG7pr=DYD=LHt5X4g@mail.gmail.com>
	 <CA+Tgmoap_uDKU6K5ch1m=7fiKiEHhbAHWF4EDMhAVG-qdmi=0Q@mail.gmail.com>
	 <d7e0869ed38353097293b686ca8d033b36d9c361.camel@j-davis.com>
	 <CA+TgmoaFpHyW1ZwCjNxJmvCR0NRMLYCkA=O50BCKLGnC1UcJNg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/db541ea000b2371c323c1f5c00ebca2c3a3e28c0.camel%40j-davis.com>
Precedence: bulk

On Tue, 2025-04-01 at 09:37 -0400, Robert Haas wrote:
> I don't think I was aware of the open item; I was just catching up on
> email.

I lean towards making it opt-in for pg_dump and opt-out for pg_upgrade.
But I think we should leave open the possibility for changing the
default to opt-out for pg_dump in the future.

My reasoning for pg_dump is that releasing with stats as opt-in doesn't
put us in a worse position for making it opt-out later, so long as we
have the right set of both positive and negative options. It may even
be a better position because people have time to make their scripts
future proof by using the right combination of options.

> But I also don't really see the value of waiting until beta to
> make this decision. I seriously doubt that my opinion is going to
> change. Maybe other people's will, though: I can only speak for
> myself.

I don't think the last week before feature freeze, deep in a 400-email
thread is the best way to make decisions like this. Let's at least have
a focused thread on this topic and see if we can solicit opinions from
both sides.

Also, waiting to see if the performance improvements make it in, or
waiting for beta reports, may yield some new information that could
change minds.

Mid-beta might be too long, but let's wait for the final CF to settle
and give people the chance to respond to a top-level thread?

Regards,
	Jeff Davis