Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxxC-0004rb-B0 for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Jul 2017 10:36:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dVxxB-0007Oj-PH for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Jul 2017 10:36:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dVxxA-0007Mb-TE for pgsql-hackers@postgresql.org; Fri, 14 Jul 2017 10:36:08 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxx7-0005mm-Fg for pgsql-hackers@postgresql.org; Fri, 14 Jul 2017 10:36:08 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 1C2B521C03F6; Fri, 14 Jul 2017 13:36:05 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1500028564; bh=mJN4ZlQbihBWdVoiPAoohqTsoiX/k5MuCCZBLqnXKbk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=mgE0fin+nyKBDQXeTKrCAEl3bJYaS7tiD8OkgV3OqAdIKzhPmRQnLiUshQVi2btIt UMJ7+QpkfdoWao3I5dSiMGstz6CNFhEDquHnjDBLvG4St2/Ml2npxVzTsLEvyh2XfF trqVtyE4yt/fY+5w8mBf3l7D+E0ffKH9uTWOPlYc= Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Jul 2017 13:36:02 +0300 From: Marina Polyakova To: Fabien COELHO Cc: PostgreSQL Developers , Kevin Grittner , Andres Freund , Alvaro Herrera , Thomas Munro , Robert Haas Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors Organization: Postgres Professional In-Reply-To: References: <72a0d590d6ba06f242d75c2e641820ec@postgrespro.ru> <6b4a7fb36c9956595a89a08e5368a9c5@postgrespro.ru> <01df6ca86c78e2c80b4e4d021c99d53a@postgrespro.ru> <898b57f7c12b6bd0484f8ca58fdf8436@postgrespro.ru> Message-ID: X-Sender: m.polyakova@postgrespro.ru User-Agent: Roundcube Webmail/1.2.4 List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org >>> I was not convinced by the overall memory management around variables >>> to begin with, and it is even less so with their new copy management. >>> Maybe having a clean "Variables" data structure could help improve >>> the >>> situation. > > Note that there is something for psql (src/bin/psql/variable.c) which > may or may not be shared. It should be checked before recoding > eventually the same thing. Thank you very much for pointing this file! As I checked this is another structure: here there's a simple list, while in pgbench we should know if the list is sorted and the number of elements in the list. How do you think, is it a good idea to name a variables structure in pgbench in the same way (VariableSpace) or it should be different not to be confused (Variables, for example)? -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers