public inbox for [email protected]  

help / color / mirror / Atom feed

From: Quan Zongliang <[email protected]>
To: Aleksander Alekseev <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Little refactoring of portalcmds.c
Date: Mon, 27 Oct 2025 14:02:41 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJ7c6TOQq=R5MmrbkrGYdqTQEaaoEgMq-ZraXPjkdCJ60oJcaQ@mail.gmail.com>
References: <CAJ7c6TOQq=R5MmrbkrGYdqTQEaaoEgMq-ZraXPjkdCJ60oJcaQ@mail.gmail.com>



On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
> 
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
> 

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Little refactoring of portalcmds.c
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox