Subject: Re: [HACKERS] logical decoding of two-phase transactions
To: Amit Kapila <amit.kapila16@gmail.com>,
  Ajin Cherian <itsajin@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
  Peter Smith <smithpb2250@gmail.com>,
  PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: 
 <CAMGcDxeqEpWj3fTXwqhSwBdXd2RS9jzwWscO-XbeCfso6ts3+Q@mail.gmail.com>
 <CAA4eK1+AspMGJEyoh4bc-wJ3fqYtFfAf375xOXBLJQKf8WCTQQ@mail.gmail.com>
 <CAA4eK1Jny30bcYZ7yQdaKu16ruw3J891vbagnOFChuqxCThwYA@mail.gmail.com>
 <CAFPTHDaZGYTGhwwaOwPHdanpz0qH8u9z49QEG93BTWr66QnpTg@mail.gmail.com>
 <CAA4eK1L3p4z+9wtK77MbdpkagR4GS2Y3r1Je7ZEvLQVF9GArfg@mail.gmail.com>
 <CAFPTHDYnRKDvzgDxoMn_CKqXA-D0MtrbyJvfvjBsO4G=UHDXkg@mail.gmail.com>
 <CAA4eK1KAJafQ8D5TnoL9RMrg5OMaCXiftUbc5z57=2dSr84cWw@mail.gmail.com>
 <CAFPTHDZMJC1-cNFk32xoVYGq15hp+cF4=MMfuwxRt7N2eSoJSA@mail.gmail.com>
 <CAD21AoA9n6qmLH2phB+rwSUgx+AzWYNj-A7M4dq4ZZUBTCt0nw@mail.gmail.com>
 <CAFPTHDb_wDLSQixranv9Gy1jspzwbcpHFjPugizs_wH+cXypDg@mail.gmail.com>
 <CAA4eK1Luw0c6B-WuO5v2EhiSrztgvSS_eo+7y5rYR622scMu2A@mail.gmail.com>
 <CAA4eK1J7TiOQSiDq9MS_4k7zr4Jca7SnO8Vy3L4wtc7t1X9zsQ@mail.gmail.com>
 <CAFPTHDbBmCb2DNRozDrkQ42=4Dam5XFjUnfZ9Ca--AVN=7CT7A@mail.gmail.com>
 <CAA4eK1KC_ZRKCMdeoWrVPtK_2=UM9715YwuVhO0sAnhqpe75jg@mail.gmail.com>
From: Markus Wanner <markus@bluegap.ch>
Message-ID: <dbec82e2-dbd7-95a2-c6b6-e488cbbdf853@bluegap.ch>
Date: Mon, 22 Feb 2021 18:34:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: 
 <CAA4eK1KC_ZRKCMdeoWrVPtK_2=UM9715YwuVhO0sAnhqpe75jg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Amit,

On 04.01.21 09:18, Amit Kapila wrote:
> Thanks, I have pushed the 0001* patch after making the above and a few
> other cosmetic modifications.

That commit added the following snippet to the top of 
ReorderBufferFinishPrepared:

   txn = ReorderBufferTXNByXid(rb, xid, true, NULL, commit_lsn, false);

   /* unknown transaction, nothing to do */
   if (txn == NULL)
       return;

Passing true for the create argument seems like an oversight.  I think 
this should pass false and not ever (have to) create a ReorderBufferTXN 
entry.

Regards

Markus