Message-ID: <dc574fea-c83e-a600-08cd-10881762e4fa@gmail.com>
Date: Fri, 2 Feb 2024 12:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: ResourceOwner refactoring
Content-Language: en-US
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Julien Rouhaud <rjuju123@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>
References: 
 <CAOBaU_Z-NaqzAv=9YntFjbJhgWkJDAwCVyzvKUQTJ2UKgK4AOw@mail.gmail.com>
 <2e10b71b-352e-b97b-1e47-658e2669cecb@iki.fi>
 <20221101001523.lsgmohl6fjwppbgx@awork3.anarazel.de>
 <9a3245db-ca03-4a47-5706-73404cfe5108@iki.fi>
 <20221101154251.64vyq7wy6w7aykrn@awork3.anarazel.de>
 <bf88d2a9-a7bc-3d68-57e3-abfba87832e9@iki.fi>
 <CAJ7c6TNijrJ+0hnTiAPDBn-tCiJsk-yvpF3Y8rXG4gTw09JYbg@mail.gmail.com>
 <d17d4d6b-c39c-7e40-9f3d-b09f19e5ccec@iki.fi>
 <CAJ7c6TM_9XtQX6xAGkH2u2-b20z-1rii9szMdW-aMHJZC_NOsA@mail.gmail.com>
 <527af829-4a03-03b0-121c-46ff79c61887@iki.fi>
 <20230710191446.pn5ltm73t2i3xtxz@awork3.anarazel.de>
 <20607b96-b275-4a57-8509-29a3ed320d3f@iki.fi>
 <48b16f57-4204-4bd2-ab42-fb24144649c4@eisentraut.org>
 <bf814230-4172-47ce-a47c-6212ee6d298e@iki.fi>
 <9cb1277d-aee4-6511-44ee-7924676f7756@gmail.com>
 <599c6674-d40b-4b31-9251-c5c073ff9fdc@iki.fi>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <599c6674-d40b-4b31-9251-c5c073ff9fdc@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/dc574fea-c83e-a600-08cd-10881762e4fa%40gmail.com>
Precedence: bulk

Hello Heikki,

08.11.2023 14:37, Heikki Linnakangas wrote:
>
> Fixed these, and pushed. Thanks everyone for reviewing!
>

Please try the following script:
mkdir /tmp/50m
sudo mount -t tmpfs -o size=50M tmpfs /tmp/50m
export PGDATA=/tmp/50m/tmpdb

initdb
pg_ctl -l server.log start

cat << 'EOF' | psql
CREATE TEMP TABLE t (a name, b name, c name, d name);
INSERT INTO t SELECT 'a', 'b', 'c', 'd' FROM generate_series(1, 1000) g;

COPY t TO '/tmp/t.data';
SELECT 'COPY t FROM ''/tmp/t.data''' FROM generate_series(1, 100)
\gexec
EOF

which produces an unexpected error, a warning, and an assertion failure,
starting from b8bff07da:
..
COPY 1000
ERROR:  could not extend file "base/5/t2_16386" with FileFallocate(): No space left on device
HINT:  Check free disk space.
CONTEXT:  COPY t, line 1000
ERROR:  ResourceOwnerRemember called but array was full
CONTEXT:  COPY t, line 1000
WARNING:  local buffer refcount leak: [-499] (rel=base/5/t2_16386, blockNum=1483, flags=0x2000000, refcount=0 1)
server closed the connection unexpectedly
         This probably means the server terminated abnormally
         before or while processing the request.
connection to server was lost
2024-02-02 08:29:24.434 UTC [2052831] LOG:  server process (PID 2052839) was terminated by signal 6: Aborted

server.log contains:
TRAP: failed Assert("RefCountErrors == 0"), File: "localbuf.c", Line: 804, PID: 2052839

Best regards,
Alexander